Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump nokogiri to 1.11.0 #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −10
Open

Bump nokogiri to 1.11.0 #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ source "https://rubygems.org" do
gem "faraday_middleware", "~> 1.0.0.rc1", :require => false
gem "net-http-persistent", "~> 4.0", :require => false
if RUBY_VERSION.start_with?("2.3") then
gem "nokogiri", "~> 1.10.4", :require => false
gem "nokogiri", "~> 1.10.4", :require => false
else
gem "nokogiri", "~> 1.11.0.rc2", :require => false
gem "nokogiri", "~> 1.11.0", :require => false
end
Comment on lines 30 to 34
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tancnle nokogiri dropped Ruby 2.4 support at 1.1.0.rc4. So you need to enforce 1.11.0 on 2.4 somehow, or you need to put a branch for 2.4 between if and else:

elif RUBY_VERSION.start_with("2.4") then
  gem "nokogiri",            "~> 1.11.0.rc2", :require => false

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onlined Excellent point 👍. That was an oversight on my part. Adding an additional branch to handle 2.4 is definitely doable. However, given the Ruby 2.4 support drop, I don't think this PR is adding much value (i.e. users can still lock the preferred nokogiri version given their Ruby version constraint).

If there is any plan to drop support for 2.4 altogether as it is EOL'ed and soon 2.5 (https://www.ruby-lang.org/en/downloads/), we can remove these conditionals and cut a major version bump of this gem. IMHO, that would be a more preferable approach.


gem "adal", "~> 1.0", :require => false
Expand Down
4 changes: 2 additions & 2 deletions blob/azure-storage-blob.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ Gem::Specification.new do |s|

s.add_runtime_dependency("azure-storage-common", "~> 2.0")
if RUBY_VERSION < "2.4.0"
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
else
s.add_runtime_dependency("nokogiri", "~> 1.11.0.rc2")
s.add_runtime_dependency("nokogiri", "~> 1.11.0")
end

s.add_development_dependency("dotenv", "~> 2.0")
Expand Down
4 changes: 2 additions & 2 deletions file/azure-storage-file.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ Gem::Specification.new do |s|

s.add_runtime_dependency("azure-storage-common", "~> 2.0")
if RUBY_VERSION < "2.4.0"
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
else
s.add_runtime_dependency("nokogiri", "~> 1.11.0.rc2")
s.add_runtime_dependency("nokogiri", "~> 1.11.0")
end

s.add_development_dependency("dotenv", "~> 2.0")
Expand Down
4 changes: 2 additions & 2 deletions queue/azure-storage-queue.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ Gem::Specification.new do |s|

s.add_runtime_dependency("azure-storage-common", "~> 2.0")
if RUBY_VERSION < "2.4.0"
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
else
s.add_runtime_dependency("nokogiri", "~> 1.11.0.rc2")
s.add_runtime_dependency("nokogiri", "~> 1.11.0")
end

s.add_development_dependency("dotenv", "~> 2.0")
Expand Down
4 changes: 2 additions & 2 deletions table/azure-storage-table.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ Gem::Specification.new do |s|

s.add_runtime_dependency("azure-storage-common", "~> 2.0")
if RUBY_VERSION < "2.4.0"
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
else
s.add_runtime_dependency("nokogiri", "~> 1.11.0.rc2")
s.add_runtime_dependency("nokogiri", "~> 1.11.0")
end

s.add_development_dependency("dotenv", "~> 2.0")
Expand Down