Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Action: Add version and version format check. #335

Merged
merged 17 commits into from
Jun 23, 2023
Merged

Github Action: Add version and version format check. #335

merged 17 commits into from
Jun 23, 2023

Conversation

DannyDaoBoYang
Copy link
Contributor

@DannyDaoBoYang DannyDaoBoYang commented Jun 20, 2023 •
edited
Loading

Why

Add version Number format check
Make bmx --version work

@github-actions github-actions bot added language/csharp size/XS A very small PR - good job! labels Jun 20, 2023
@DannyDaoBoYang DannyDaoBoYang changed the title Add version Project: Add version Jun 20, 2023
@DannyDaoBoYang DannyDaoBoYang changed the title Project: Add version Project File: Add version Jun 20, 2023
@github-actions github-actions bot added size/S A small PR. and removed size/XS A very small PR - good job! labels Jun 22, 2023
@DannyDaoBoYang DannyDaoBoYang marked this pull request as ready for review June 22, 2023 18:35
@DannyDaoBoYang DannyDaoBoYang changed the title Project File: Add version Github Action and Project File: Add version, and version format check. Jun 23, 2023
cfbao
cfbao reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@cfbao cfbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title should be updated

.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
@DannyDaoBoYang DannyDaoBoYang changed the title Github Action and Project File: Add version, and version format check. Github Action: Add version, and version format check. Jun 23, 2023
@DannyDaoBoYang DannyDaoBoYang changed the title Github Action: Add version, and version format check. Github Action: Add version and version format check. Jun 23, 2023
@DannyDaoBoYang DannyDaoBoYang merged commit 23b0016 into main Jun 23, 2023
8 checks passed
@DannyDaoBoYang DannyDaoBoYang deleted the make_version_great_again branch June 23, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfbao cfbao cfbao approved these changes

@jharoutuniand2l jharoutuniand2l Awaiting requested review from jharoutuniand2l

@scowing scowing Awaiting requested review from scowing

@boarnoah boarnoah Awaiting requested review from boarnoah

@gord5500 gord5500 Awaiting requested review from gord5500

Assignees
No one assigned
Labels
area/github-actions language/csharp size/S A small PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DannyDaoBoYang @cfbao