Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Action: Add version and version format check. #335

Merged
merged 17 commits into from
Jun 23, 2023
Merged

Github Action: Add version and version format check. #335

Changes from 15 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c2f0481
Add version
DannyDaoBoYang Jun 19, 2023
a5b5ea0
Merge branch 'main' into make_version_great_again
DannyDaoBoYang Jun 20, 2023
fc7a57f
Add Version Format Check
DannyDaoBoYang Jun 20, 2023
a2a56f0
Add version check
DannyDaoBoYang Jun 22, 2023
fa9dede
not display commithash
DannyDaoBoYang Jun 22, 2023
52a8703
Merge branch 'main' into make_version_great_again
DannyDaoBoYang Jun 22, 2023
ae7ad72
let's see
DannyDaoBoYang Jun 22, 2023
134ceca
default version
DannyDaoBoYang Jun 22, 2023
db5eaff
Merge branch 'main' into make_version_great_again
DannyDaoBoYang Jun 22, 2023
cdfcb00
Update publish.yml
DannyDaoBoYang Jun 22, 2023
8703116
spaces
DannyDaoBoYang Jun 22, 2023
ba8b949
Update publish.yml
DannyDaoBoYang Jun 22, 2023
68fd92a
Update publish.yml
DannyDaoBoYang Jun 22, 2023
4f1bfe9
Update publish.yml
DannyDaoBoYang Jun 22, 2023
6cc4b3c
typo
DannyDaoBoYang Jun 22, 2023
805ff07
Update publish.yml
DannyDaoBoYang Jun 23, 2023
a4dc2a0
Apply suggestions from code review
DannyDaoBoYang Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ jobs:
GH_TOKEN: ${{ github.token }}
shell: pwsh
run: |
if ( -Not ( $env:RELEASE_TAG -match '^v3\.[0-9]+\.[0-9]+(-preview)*$' ) ){
DannyDaoBoYang marked this conversation as resolved.
Show resolved Hide resolved
echo "Tag name format incorrect"
exit(1)
DannyDaoBoYang marked this conversation as resolved.
Show resolved Hide resolved
}
if ($env:PRERELEASE -eq 'true') {
$releaseUrl = gh release create "$env:RELEASE_TAG" --repo Brightspace/bmx --draft --prerelease --generate-notes --title "Release $env:RELEASE_TAG"
} else {
Expand Down Expand Up @@ -73,9 +77,16 @@ jobs:

- name: publish
shell: pwsh
env:
RELEASE_TAG: ${{ github.event.inputs.release_tag }}
working-directory: src/D2L.Bmx
run: |
dotnet publish -r $env:PLATFORM-x64 -o build
$version = "$env:RELEASE_TAG"
if ( -not $version -or $version -eq '' ){
DannyDaoBoYang marked this conversation as resolved.
Show resolved Hide resolved
$version = "v3.0.0"
}
$versionWithoutv = "$version".TrimStart("v")
dotnet publish /p:Version="$versionWithoutv" /p:InformationalVersion="$version" /p:IncludeSourceRevisionInInformationalVersion=false -r $env:PLATFORM-x64 -o build
DannyDaoBoYang marked this conversation as resolved.
Show resolved Hide resolved

- name: check size
shell: pwsh
Expand Down