'build' is a little confusing in this context #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d()' function which is not used here but the 'create()' function.
| @@ -167,7 +167,7 @@ factory_boy supports several different build strategies: build, create, and stub | |||
| obj = UserFactory.stub() | |||
|
|
|||
|
|
|||
| You can use the Factory class as a shortcut for the default build strategy: | |||
There was a problem hiding this comment.
Replacing build by create does not help clarity in this context IMO. Line 155 explains that:
factory_boy supports several different build strategies: build, create, and stub
A build strategy is the strategy used to make an object. I think we should unify the terminology, if possible on a word that is not also a strategy. Perhaps “instantiation strategy”?
There was a problem hiding this comment.
I'd rather go for generation strategy then:
- Instantiation is literally instantiating the class;
- The code already provides a set of endpoints for which the user can choose the strategy, and they are named
generate:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'build' is a little confusing in this context, since there is a 'build()' function which is not used here but the 'create()' function.