Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'build' is a little confusing in this context #768

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ factory_boy supports several different build strategies: build, create, and stub
obj = UserFactory.stub()


You can use the Factory class as a shortcut for the default build strategy:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing build by create does not help clarity in this context IMO. Line 155 explains that:

factory_boy supports several different build strategies: build, create, and stub

A build strategy is the strategy used to make an object. I think we should unify the terminology, if possible on a word that is not also a strategy. Perhaps “instantiation strategy”?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather go for generation strategy then:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that’s better.

You can use the Factory class as a shortcut for the default create strategy:

.. code-block:: python

Expand Down