Testing go 1.16 RC1

[fxcoudert]

• Draft release notes: https://tip.golang.org/doc/go1.16
• Release candidate announcement: https://groups.google.com/g/golang-announce/c/U_FUHY4wuSc/m/3_Vw3oqpAgAJ

In particular:

Module-aware mode is enabled by default, regardless of whether a go.mod file is present in the current working directory or a parent directory. More precisely, the GO111MODULE environment variable now defaults to on. To switch to the previous behavior, set GO111MODULE to auto.

[fxcoudert]

From the 10.15 results, we have 101 failures out of 526 formulas that directly depend on go:

brew install --build-from-source ahoy
brew install --build-from-source akamai
brew install --build-from-source amazon-ecs-cli
brew install --build-from-source apache-brooklyn-cli
brew install --build-from-source aptly
brew install --build-from-source assh
brew install --build-from-source bitrise
brew install --build-from-source buildifier
brew install --build-from-source buildozer
brew install --build-from-source caddy
brew install --build-from-source carina
brew install --build-from-source cartridge-cli
brew install --build-from-source ccat
brew install --build-from-source cf-tool
brew install --build-from-source charm
brew install --build-from-source charm-tools
brew install --build-from-source collector-sidecar
brew install --build-from-source confd
brew install --build-from-source cosi
brew install --build-from-source cql
brew install --build-from-source cwlogs
brew install --build-from-source devd
brew install --build-from-source docker-credential-helper
brew install --build-from-source docker-credential-helper-ecr
brew install --build-from-source docker-gen
brew install --build-from-source docker-machine-driver-hyperkit
brew install --build-from-source docker-machine-driver-vmware
brew install --build-from-source docker-machine-driver-vultr
brew install --build-from-source docker-swarm
brew install --build-from-source docker2aci
brew install --build-from-source dockerize
brew install --build-from-source dockviz
brew install --build-from-source dockward
brew install --build-from-source dvm
brew install --build-from-source emp
brew install --build-from-source envoy
brew install --build-from-source flint-checker
brew install --build-from-source fsql
brew install --build-from-source gdm
brew install --build-from-source gdrive
brew install --build-from-source git-appraise
brew install --build-from-source git-sizer
brew install --build-from-source github-release
brew install --build-from-source gollum
brew install --build-from-source gotags
brew install --build-from-source gx-go
brew install --build-from-source hivemind
brew install --build-from-source httpdiff
brew install --build-from-source ioctl
brew install --build-from-source ironcli
brew install --build-from-source jabba
brew install --build-from-source jp
brew install --build-from-source jsonpp
brew install --build-from-source kamel
brew install --build-from-source kedge
brew install --build-from-source ksync
brew install --build-from-source launch_socket_server
brew install --build-from-source leaps
brew install --build-from-source lunchy-go
brew install --build-from-source mailhog
brew install --build-from-source massren
brew install --build-from-source microplane
brew install --build-from-source modd
brew install --build-from-source mpdviz
brew install --build-from-source path-extractor
brew install --build-from-source pgweb
brew install --build-from-source piknik
brew install --build-from-source pup
brew install --build-from-source qpm
brew install --build-from-source rack
brew install --build-from-source rancher-compose
brew install --build-from-source rke
brew install --build-from-source s-search
brew install --build-from-source scc
brew install --build-from-source shellz
brew install --build-from-source ship
brew install --build-from-source sift
brew install --build-from-source snag
brew install --build-from-source snap-telemetry
brew install --build-from-source spaceinvaders-go
brew install --build-from-source ssh-vault
brew install --build-from-source stout
brew install --build-from-source sync_gateway
brew install --build-from-source td
brew install --build-from-source teleconsole
brew install --build-from-source termshare
brew install --build-from-source terraform-inventory
brew install --build-from-source textql
brew install --build-from-source traefik@1
brew install --build-from-source uru
brew install --build-from-source vert
brew install --build-from-source vultr
brew install --build-from-source wego
brew test --retry --verbose bitrise
brew test --retry --verbose cloudformation-cli
brew test --retry --verbose fortio
brew test --retry --verbose gdm
brew test --retry --verbose gox
brew test --retry --verbose gpm
brew test --retry --verbose packr
brew test --retry --verbose terrascan

[fxcoudert]

Trying to see how many of these are fixed just by setting ENV["GO111MODULE"] = "auto"

[fxcoudert]

And we're down to 20!

brew fetch --retry ioctl --build-bottle --force
brew install --build-from-source armor
brew install --build-from-source charm
brew install --verbose --build-bottle assh
brew install --verbose --build-bottle buildifier
brew install --verbose --build-bottle buildozer
brew install --verbose --build-bottle caddy
brew install --verbose --build-bottle cartridge-cli
brew install --verbose --build-bottle charm
brew install --verbose --build-bottle charm-tools
brew install --verbose --build-bottle envoy
brew install --verbose --build-bottle ioctl
brew install --verbose --build-bottle ksync
brew test --retry --verbose cloudformation-cli
brew test --retry --verbose gox
brew test --retry --verbose gpm
brew test --retry --verbose packr
brew test --retry --verbose terrascan
brew test --verbose bitrise
brew test --verbose gdm

• armor: failed to fetch source
• charm: github.com/Microsoft/[email protected] requires golang.org/x/[email protected] (replaced by golang.org/x/[email protected]): missing go.sum entry
• ioctl: checksum mismatch
• assh: missing go.sum entry for module providing package github.com/spf13/viper
• buildifier, buildozer: bazel errors

[andig]

Trying to see how many of these are fixed just by setting ENV["GO111MODULE"] = "auto"

@fxcoudert does that change anything? Imho it shouldn't as that would be the default anyway and doesn't change with go1.16?

As I'm anxiously waiting for 1.16- is there anything I could help with (and how can I use the local go1.16rc1 for the purpose)?

[fxcoudert]

that would be the default anyway and doesn't change with go1.16

It does change, read the release notes I quoted above

[fxcoudert]

is there anything I could help with

Look at the build logs for the failures indicated above, and help us collectively find a way to fix those.

[andig]

Module-aware mode is enabled by default, regardless of whether a go.mod file is present in the current working directory or a parent directory. More precisely, the GO111MODULE environment variable now defaults to on. To switch to the previous behavior, set GO111MODULE to auto.

ahh, that had escaped my attention, thank you!

how can I use the local go1.16rc1 for the purpose)

GOBIN=$(which go1.16rc1) brew install ...

doesn't to the trick for me?

[andig]

• charm: was already broken last time (Does not work with Python 3.9 juju/charm-tools#586) - finally disable, including charm-tools?
• ioctl: checksum mismatch (what to do about those?) see go 1.15.8 #70446 (comment)
• ksync: go1.16rc1 build fails ksync/ksync#490

[andig]

I couldn't figure out assh (https://github.com/Homebrew/homebrew-core/blob/master/Formula/assh.rb). With go 1.16rc1 installed, it still insists on installing go1.15.7:

❯ brew install --verbose --build-bottle assh
==> Downloading https://homebrew.bintray.com/bottles/go-1.15.7_1.big_sur.bottle.tar.gz
/usr/bin/curl --disable --globoff --show-error --user-agent Homebrew/3.0.0-27-g1d48624\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 11.2\)\ curl/7.64.1 --header Accept-Language:\ en --retry 3 --location --silent --head --request GET https://homebrew.bintray.com/bottles/go-1.15.7_1.big_sur.bottle.tar.gz
Already downloaded: /Users/andig/Library/Caches/Homebrew/downloads/e7d14b21a5d2765e2290f539eb478ff025056c94976b9550e80e01daf307bef9--go-1.15.7_1.big_sur.bottle.tar.gz
==> Verifying checksum for 'e7d14b21a5d2765e2290f539eb478ff025056c94976b9550e80e01daf307bef9--go-1.15.7_1.big_sur.bottle.tar.gz'
==> Downloading https://github.com/moul/assh/archive/v2.11.0.tar.gz
/usr/bin/curl --disable --globoff --show-error --user-agent Homebrew/3.0.0-27-g1d48624\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 11.2\)\ curl/7.64.1 --header Accept-Language:\ en --retry 3 --location --silent --head --request GET https://github.com/moul/assh/archive/v2.11.0.tar.gz
Already downloaded: /Users/andig/Library/Caches/Homebrew/downloads/12c9d80f809c19cfd6889378378b009087e2301f9b94f2afb7f0c0019419116a--assh-2.11.0.tar.gz
==> Verifying checksum for '12c9d80f809c19cfd6889378378b009087e2301f9b94f2afb7f0c0019419116a--assh-2.11.0.tar.gz'
==> Installing dependencies for assh: go
==> Installing assh dependency: go
==> Pouring go-1.15.7_1.big_sur.bottle.tar.gz
tar xof /Users/andig/Library/Caches/Homebrew/downloads/e7d14b21a5d2765e2290f539eb478ff025056c94976b9550e80e01daf307bef9--go-1.15.7_1.big_sur.bottle.tar.gz -C /var/folders/73/89ycv7qn51j4kbm04jsz9b840000gn/T/d20210208-2186-dl6p10
cp -pR /var/folders/73/89ycv7qn51j4kbm04jsz9b840000gn/T/d20210208-2186-dl6p10/go/. /usr/local/Cellar/goa

[andig]

• buildifier: 3.5.0 doesn't build, open PR for 4.0: buildifier 4.0.0 #70328
• buildozer: same

[SMillerDev]

I couldn't figure out assh (https://github.com/Homebrew/homebrew-core/blob/master/Formula/assh.rb). With go 1.16rc1 installed, it still insists on installing go1.15.7:

That's how go 1.16 RC1 identifies itself on M1

[andig]

I couldn't figure out assh (https://github.com/Homebrew/homebrew-core/blob/master/Formula/assh.rb). With go 1.16rc1 installed, it still insists on installing go1.15.7:

That's how go 1.16 RC1 identifies itself on M1

I'm not on M1 but Intel and have RC1 installed using the go package (not brew). It's apparently not being picked up as brew seems to insist on /usr/local/opt/go:

❯ which go
/usr/local/go/bin/go

[SMillerDev]

No, brew will always use packages it manages. There's too many issues otherwise

[andig]

No, brew will always use packages it manages. There's too many issues otherwise

Ok. Feeling stupid today: how can I install 1.16rc1 locally then to support the brew testing efforts? Feels I'm running round in circles not being very helpful :O

[SMillerDev]

how can I install 1.16rc1 locally then to support the brew testing efforts?

You can brew pr-pull <this PR number> and then brew install -s go. That'll install go as it is in this formula.

[SMillerDev]

Closing this since Go 1.16 is released and updated in #71289