Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract intermediate table in QuickSight dataset #990

Merged

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Sep 25, 2024

🤔 Why?

To get the intermediate logical (physical) tables of a QuickSight as non-prod tables. This way allows us to parse CLL easier, and get extra information about how QS dataset is configured.

🤓 What?

  • Rewrite the logic about table lineage, instead of computing the final lineage between data source table and dataset, we get the detail lineage

🧪 Tested?

Test it end-to-end

image

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12629 11291 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/looker/lookml_parser.py 94% 🟢
metaphor/quick_sight/extractor.py 95% 🟢
metaphor/quick_sight/lineage.py 89% 🟢
TOTAL 92% 🟢

updated for commit: 8040d4b by action🐍

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 87.40741% with 17 lines in your changes missing coverage. Please review.

Project coverage is 89.40%. Comparing base (026c102) to head (8040d4b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/quick_sight/lineage.py 86.61% 17 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #990   +/-   ##
=======================================
  Coverage   89.39%   89.40%           
=======================================
  Files         193      193           
  Lines       12591    12629   +38     
=======================================
+ Hits        11256    11291   +35     
- Misses       1335     1338    +3     
Flag Coverage Δ
89.40% <87.40%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elic-eon elic-eon changed the title Scotthuang/sc 28854/process quicksight dataset lineage on server Extract intermediate table in QuickSight dataset Sep 25, 2024
@elic-eon elic-eon marked this pull request as ready for review September 25, 2024 16:16
@elic-eon elic-eon merged commit f5c453b into main Sep 25, 2024
5 of 6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-28854/process-quicksight-dataset-lineage-on-server branch September 25, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants