Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract intermediate table in QuickSight dataset #990

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Extract intermediate table in QuickSight dataset #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2709019
Extract internal QS table
elic-eon Sep 25, 2024
8040d4b
bump version
elic-eon Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions metaphor/looker/lookml_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@
LookerView,
LookerViewDimension,
LookerViewMeasure,
LookerViewQuery,
SystemTag,
SystemTags,
SystemTagSource,
VirtualView,
VirtualViewLogicalID,
VirtualViewQuery,
VirtualViewType,
)

Expand Down Expand Up @@ -132,7 +132,7 @@ def _get_upstream_and_query(
view_name: str,
raw_model: RawModel,
connection: LookerConnectionConfig,
) -> Tuple[Set[EntityId], Optional[LookerViewQuery]]:
) -> Tuple[Set[EntityId], Optional[VirtualViewQuery]]:
raw_views = raw_model.raw_views
raw_view = raw_views.get(view_name)
if raw_view is None:
Expand All @@ -150,7 +150,7 @@ def _get_upstream_and_query(
derived_table: Optional[Dict] = raw_view.get("derived_table")
if derived_table is not None:
if "sql" in derived_table:
query = LookerViewQuery(
query = VirtualViewQuery(
query=derived_table["sql"],
source_platform=connection.platform,
source_dataset_account=connection.account,
Expand Down
25 changes: 11 additions & 14 deletions metaphor/quick_sight/extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,7 @@
DATA_SET_DIRECTORIES,
create_top_level_folders,
)
from metaphor.quick_sight.lineage import (
extract_virtual_view_schema,
extract_virtual_view_upstream,
process_dataset_lineage,
)
from metaphor.quick_sight.lineage import LineageProcessor
from metaphor.quick_sight.models import Dashboard, DataSet, ResourceType

logger = get_logger()
Expand Down Expand Up @@ -80,15 +76,16 @@ def _extract_virtual_views(self):
continue

view = self._init_virtual_view(data_set.Arn, data_set)

columns, source_entities = process_dataset_lineage(
self._resources, data_set
)

view.schema = extract_virtual_view_schema(data_set, columns)
view.entity_upstream = extract_virtual_view_upstream(
columns, source_entities
)
output_logical_table_id = LineageProcessor(
self._resources, self._virtual_views, data_set
).run()

# The last logical_table is the output table for the dataset
output = self._virtual_views.get(output_logical_table_id)
if output:
view.schema = output.schema
view.entity_upstream = output.entity_upstream
self._virtual_views.pop(output_logical_table_id)

def _extract_dashboards(self) -> None:
for dashboard in self._resources.values():
Expand Down
Loading
Loading