Pickles async circuits #15084
Merged
Pickles async circuits #15084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
mrmr1993
commented
Feb 20, 2024
|
!ci-build-me |
|
Tested and working in o1js here: o1-labs/o1js#1450 |
mitschabaude
approved these changes
Feb 27, 2024
|
Heads up @mrmr1993 - this seems to change all verification keys |
rbonichon
suggested changes
Feb 29, 2024
|
!ci-build-me |
SanabriaRusso
approved these changes
Mar 5, 2024
|
!ci-build-me |
|
!ci-build-me |
rbonichon
approved these changes
Mar 6, 2024
emberian
approved these changes
Mar 7, 2024
mrmr1993
commented
Mar 12, 2024
| @@ -243,6 +248,37 @@ module Storables = struct | |||
| } | |||
| end | |||
|
|
|||
| let create_lock () = | |||
There was a problem hiding this comment.
This should never have made it into the codebase. I am annoyed.
There was a problem hiding this comment.
Disagree. It is only applied to sequencing the circuit runs that compile creates when compiling different step constraint systems. This is necessary and has none of the downsides we discussed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses MinaFoundation/Core-Grants#4