Pickles async circuits

scripts/zkapp_metrics.sh

@@ -12,5 +12,5 @@ echo "Running heap usage app"
 echo "Building zkapp limits app"
 make zkapp_limits
 
-echo "Running heap usage app"
+echo "Running zkapp limits app"
 ./_build/default/src/app/zkapp_limits/zkapp_limits.exe

src/app/cli/src/init/transaction_snark_profiler.ml

@@ -9,7 +9,8 @@ let run ~user_command_profiler ~zkapp_profiler num_transactions ~max_num_updates
   let print n msg = printf !"[%i] %s\n%!" n msg in
   if use_zkapps then (
     let ledger, transactions =
-      create_ledger_and_zkapps ?min_num_updates ~max_num_updates ()
+      Async.Thread_safe.block_on_async_exn (fun () ->
+          create_ledger_and_zkapps ?min_num_updates ~max_num_updates () )
     in
     Parallel.init_master () ;
     let verifier =

src/app/heap_usage/values.ml

@@ -36,8 +36,9 @@ let account : Mina_base.Account.t =
 let zkapp_command =
   let num_updates = 16 in
   let _ledger, zkapp_commands =
-    Snark_profiler_lib.create_ledger_and_zkapps ~min_num_updates:num_updates
-      ~num_proof_updates:num_updates ~max_num_updates:num_updates ()
+    Async.Thread_safe.block_on_async_exn (fun () ->
+        Snark_profiler_lib.create_ledger_and_zkapps ~min_num_updates:num_updates
+          ~num_proof_updates:num_updates ~max_num_updates:num_updates () )
   in
   List.hd_exn zkapp_commands
 
@@ -65,6 +66,7 @@ let verification_key =
     Transaction_snark.For_tests.create_trivial_snapp
       ~constraint_constants:Genesis_constants.Constraint_constants.compiled ()
   in
+  let vk = Async.Thread_safe.block_on_async_exn (fun () -> vk) in
   With_hash.data vk
 
 let applied = Mina_base.Transaction_status.Applied

src/app/print_blockchain_snark_vk/print_blockchain_snark_vk.ml

@@ -36,6 +36,7 @@ let () =
     (Time.Span.to_string_hum (Time.diff after before))
 
 let () =
-  Lazy.force Blockchain_snark_instance.Proof.verification_key
+  Async.Thread_safe.block_on_async_exn (fun () ->
+      Lazy.force Blockchain_snark_instance.Proof.verification_key )
   |> Pickles.Verification_key.to_yojson |> Yojson.Safe.to_string
   |> Format.print_string

src/app/test_executive/hard_fork.ml

@@ -326,8 +326,9 @@ module Make (Inputs : Intf.Test.Inputs_intf) = struct
         ; authorization_kind = Signature
         }
       in
-      Transaction_snark.For_tests.deploy_snapp ~constraint_constants
-        zkapp_command_spec
+      Async.Thread_safe.block_on_async_exn (fun () ->
+          Transaction_snark.For_tests.deploy_snapp ~constraint_constants
+            zkapp_command_spec )
     in
 
     let%bind zkapp_command_update_vk_proof, zkapp_command_update_vk_impossible =

src/app/test_executive/peers_reliability_test.ml

@@ -139,9 +139,10 @@ module Make (Inputs : Intf.Test.Inputs_intf) = struct
              }
            in
            return
-           @@ Transaction_snark.For_tests.deploy_snapp
-                ~constraint_constants:(Network.constraint_constants network)
-                parties_spec
+           @@ Async.Thread_safe.block_on_async_exn (fun () ->
+                  Transaction_snark.For_tests.deploy_snapp
+                    ~constraint_constants:(Network.constraint_constants network)
+                    parties_spec )
          in
          let%bind () =
            send_zkapp ~logger

src/app/test_executive/verification_key_update.ml

@@ -143,8 +143,12 @@ module Make (Inputs : Intf.Test.Inputs_intf) = struct
              constraint_constants )
         ~choices:(fun ~self:_ -> [ Trivial_rule2.rule ])
     in
-    let vk1 = Pickles.Side_loaded.Verification_key.of_compiled tag1 in
-    let vk2 = Pickles.Side_loaded.Verification_key.of_compiled tag2 in
+    let%bind.Async.Deferred vk1 =
+      Pickles.Side_loaded.Verification_key.of_compiled tag1
+    in
+    let%bind.Async.Deferred vk2 =
+      Pickles.Side_loaded.Verification_key.of_compiled tag2
+    in
     let%bind.Async.Deferred account_update1, _ =
       trivial_prover1 ~handler:Trivial_rule1.handler ()
     in
@@ -216,7 +220,8 @@ module Make (Inputs : Intf.Test.Inputs_intf) = struct
         ; authorization_kind = Signature
         }
       in
-      Transaction_snark.For_tests.deploy_snapp ~constraint_constants spec
+      Async.Thread_safe.block_on_async_exn (fun () ->
+          Transaction_snark.For_tests.deploy_snapp ~constraint_constants spec )
     in
     let call_forest_to_zkapp ~call_forest ~nonce : Zkapp_command.t =
       let memo = Signed_command_memo.empty in

src/app/test_executive/zkapps.ml

@@ -179,8 +179,9 @@ module Make (Inputs : Intf.Test.Inputs_intf) = struct
         }
       in
       return
-      @@ Transaction_snark.For_tests.deploy_snapp ~constraint_constants
-           zkapp_command_spec
+      @@ Async.Thread_safe.block_on_async_exn (fun () ->
+             Transaction_snark.For_tests.deploy_snapp ~constraint_constants
+               zkapp_command_spec )
     in
     let%bind.Deferred zkapp_command_update_permissions, permissions_updated =
       (* construct a Zkapp_command.t, similar to zkapp_test_transaction update-permissions *)

src/app/test_executive/zkapps_timing.ml

@@ -105,8 +105,9 @@ module Make (Inputs : Intf.Test.Inputs_intf) = struct
           Token_id.default
       in
 
-      ( Transaction_snark.For_tests.deploy_snapp ~constraint_constants
-          zkapp_command_spec
+      ( Async.Thread_safe.block_on_async_exn (fun () ->
+            Transaction_snark.For_tests.deploy_snapp ~constraint_constants
+              zkapp_command_spec )
       , timing_account_id
       , zkapp_command_spec.snapp_update
       , zkapp_keypair )
@@ -150,8 +151,9 @@ module Make (Inputs : Intf.Test.Inputs_intf) = struct
         }
       in
       return
-      @@ Transaction_snark.For_tests.deploy_snapp ~constraint_constants
-           zkapp_command_spec
+      @@ Async.Thread_safe.block_on_async_exn (fun () ->
+             Transaction_snark.For_tests.deploy_snapp ~constraint_constants
+               zkapp_command_spec )
     in
     (* Create a timed account that with initial liquid balance being 0, and vesting 1 mina at each slot.
        This account would be used to test the edge case of vesting. See `zkapp_command_transfer_from_third_timed_account`
@@ -200,8 +202,9 @@ module Make (Inputs : Intf.Test.Inputs_intf) = struct
           (zkapp_keypair.public_key |> Signature_lib.Public_key.compress)
           Token_id.default
       in
-      ( Transaction_snark.For_tests.deploy_snapp ~constraint_constants
-          zkapp_command_spec
+      ( Async.Thread_safe.block_on_async_exn (fun () ->
+            Transaction_snark.For_tests.deploy_snapp ~constraint_constants
+              zkapp_command_spec )
       , timing_account_id
       , zkapp_keypair )
     in
@@ -242,8 +245,9 @@ module Make (Inputs : Intf.Test.Inputs_intf) = struct
         ; authorization_kind = Signature
         }
       in
-      Transaction_snark.For_tests.deploy_snapp ~constraint_constants
-        zkapp_command_spec
+      Async.Thread_safe.block_on_async_exn (fun () ->
+          Transaction_snark.For_tests.deploy_snapp ~constraint_constants
+            zkapp_command_spec )
     in
     let%bind zkapp_command_transfer_from_timed_account =
       let open Mina_base in

src/app/zkapp_test_transaction/lib/commands.ml

@@ -59,9 +59,11 @@ let gen_proof ?(zkapp_account = None) (zkapp_command : Zkapp_command.t) =
       (Account.create id Currency.Balance.(of_mina_int_exn 1_000))
     |> Or_error.ok_exn
   in
-  let _v =
-    Option.value_map zkapp_account ~default:() ~f:(fun pk ->
+  let open Async.Deferred.Let_syntax in
+  let%bind () =
+    Option.value_map zkapp_account ~default:(Deferred.return ()) ~f:(fun pk ->
         let `VK vk, `Prover _ = Lazy.force vk_and_prover in
+        let%map vk = vk in
         let id = Account_id.create pk Token_id.default in
         Ledger.get_or_create_account ledger id
           { (Account.create id Currency.Balance.(of_mina_int_exn 1_000)) with
@@ -122,7 +124,6 @@ let gen_proof ?(zkapp_account = None) (zkapp_command : Zkapp_command.t) =
         , zkapp_command )
       ]
   in
-  let open Async.Deferred.Let_syntax in
   let module T = Transaction_snark.Make (struct
     let constraint_constants = constraint_constants
 
@@ -368,7 +369,7 @@ let create_zkapp_account ~debug ~sender ~sender_nonce ~fee ~fee_payer
     ; authorization_kind = Signature
     }
   in
-  let zkapp_command =
+  let%bind zkapp_command =
     Transaction_snark.For_tests.deploy_snapp
       ~permissions:Permissions.user_default ~constraint_constants spec
   in

src/app/zkapps_examples/test/actions/actions.ml

@@ -36,7 +36,9 @@ let%test_module "Actions test" =
 
     module P = (val p_module)
 
-    let vk = Pickles.Side_loaded.Verification_key.of_compiled tag
+    let vk =
+      Async.Thread_safe.block_on_async_exn (fun () ->
+          Pickles.Side_loaded.Verification_key.of_compiled tag )
 
     module Deploy_account_update = struct
       let account_update_body : Account_update.Body.t =

src/app/zkapps_examples/test/add_events/add_events.ml

@@ -36,7 +36,9 @@ let%test_module "Add events test" =
 
     module P = (val p_module)
 
-    let vk = Pickles.Side_loaded.Verification_key.of_compiled tag
+    let vk =
+      Async.Thread_safe.block_on_async_exn (fun () ->
+          Pickles.Side_loaded.Verification_key.of_compiled tag )
 
     module Deploy_account_update = struct
       let account_update_body : Account_update.Body.t =

src/app/zkapps_examples/test/big_circuit/big_circuit.ml

@@ -31,7 +31,8 @@ let tag, _cache, _p_module, Pickles.Provers.[ prover ] =
       [ Zkapps_big_circuit.rule ~num_constraints pk_compressed ] )
 
 let vk : Side_loaded_verification_key.t =
-  Pickles.Side_loaded.Verification_key.of_compiled tag
+  Async.Thread_safe.block_on_async_exn (fun () ->
+      Pickles.Side_loaded.Verification_key.of_compiled tag )
 
 let vk_hash = Mina_base.Verification_key_wire.digest_vk vk
 

src/app/zkapps_examples/test/calls/calls.ml

@@ -91,7 +91,9 @@ let%test_module "Composability test" =
 
     module P = (val p_module)
 
-    let vk = Pickles.Side_loaded.Verification_key.of_compiled tag
+    let vk =
+      Async.Thread_safe.block_on_async_exn (fun () ->
+          Pickles.Side_loaded.Verification_key.of_compiled tag )
 
     module Deploy_account_update = struct
       let account_update_body : Account_update.Body.t =

src/app/zkapps_examples/test/empty_update/empty_update.ml

@@ -28,7 +28,9 @@ let tag, _, p_module, Pickles.Provers.[ prover ] =
 
 module P = (val p_module)
 
-let vk = Pickles.Side_loaded.Verification_key.of_compiled tag
+let vk =
+  Async.Thread_safe.block_on_async_exn (fun () ->
+      Pickles.Side_loaded.Verification_key.of_compiled tag )
 
 let account_update, () = Async.Thread_safe.block_on_async_exn prover
 

src/app/zkapps_examples/test/initialize_state/initialize_state.ml

@@ -40,7 +40,9 @@ let%test_module "Initialize state test" =
 
     module P = (val p_module)
 
-    let vk = Pickles.Side_loaded.Verification_key.of_compiled tag
+    let vk =
+      Async.Thread_safe.block_on_async_exn (fun () ->
+          Pickles.Side_loaded.Verification_key.of_compiled tag )
 
     module Deploy_account_update = struct
       let account_update_body : Account_update.Body.t =

src/app/zkapps_examples/test/tokens/tokens.ml

@@ -42,7 +42,9 @@ let%test_module "Tokens test" =
 
     let owned_token_id = Account_id.derive_token_id ~owner:account_id
 
-    let vk = Lazy.force Zkapps_tokens.vk
+    let vk =
+      Async.Thread_safe.block_on_async_exn (fun () ->
+          Lazy.force Zkapps_tokens.vk )
 
     let mint_to_keys = gen_keys ()
 

src/app/zkapps_examples/tokens/zkapps_tokens.ml

@@ -691,8 +691,12 @@ module P = struct
   let verification_key =
     Lazy.bind p_module ~f:(fun (module P : Proof_intf) -> P.verification_key)
 
+  let verification_key_promise = lazy (failwith "not implemented")
+
   let id = Lazy.bind p_module ~f:(fun (module P : Proof_intf) -> P.id)
 
+  let id_promise = lazy (failwith "not implemented")
+
   let verify statements =
     let module P : Proof_intf = (val Lazy.force p_module) in
     P.verify statements

src/app/zkapps_examples/tokens/zkapps_tokens.mli

@@ -12,7 +12,7 @@ val tag :
   Pickles.Tag.t
   Lazy.t
 
-val vk : Pickles.Side_loaded.Verification_key.t Lazy.t
+val vk : Pickles.Side_loaded.Verification_key.t Async.Deferred.t Lazy.t
 
 module P :
   Pickles.Proof_intf

src/app/zkapps_examples/zkapps_examples.ml

@@ -448,6 +448,27 @@ let dummy_constraints () =
         (Kimchi_backend_common.Scalar_challenge.create x)
       : Field.t * Field.t )
 
+let exists_deferred ?request:req ?compute typ =
+  let open Snark_params.Tick.Run in
+  let open Async_kernel in
+  (* Set up a full Ivar, in case we are generating the constraint system. *)
+  let deferred = ref (Ivar.create_full ()) in
+  (* Request or compute the [Deferred.t] value. *)
+  let requested = exists ?request:req ?compute (Typ.Internal.ref ()) in
+  as_prover (fun () ->
+      (* If we are generating the witness, create a new Ivar.. *)
+      deferred := Ivar.create () ;
+      (* ..and fill it when the value we want to read resolves. *)
+      Deferred.upon (As_prover.Ref.get requested) (fun _ ->
+          Ivar.fill !deferred () ) ) ;
+  (* Await the [Deferred.t] if we're generating the witness, otherwise we
+     immediately bind over the filled Ivar and continue.
+  *)
+  Deferred.map (Ivar.read !deferred) ~f:(fun () ->
+      (* Retrieve the value by peeking in the known-resolved deferred. *)
+      exists typ ~compute:(fun () ->
+          Option.value_exn @@ Deferred.peek @@ As_prover.Ref.get requested ) )
+
 type return_type =
   { account_update : Account_update.Body.t
   ; account_update_digest : Zkapp_command.Digest.Account_update.t
@@ -590,7 +611,7 @@ let compile :
            , Zkapp_statement.t
            , return_type Prover_value.t * auxiliary_var
            , return_type * auxiliary_value )
-           H4_6.T(Pickles.Inductive_rule).t = function
+           H4_6.T(Pickles.Inductive_rule.Deferred).t = function
       | [] ->
           []
       | { identifier; prevs; main; feature_flags } :: choices ->
@@ -599,8 +620,8 @@ let compile :
           ; feature_flags
           ; main =
               (fun { Pickles.Inductive_rule.public_input = () } ->
-                let vk_hash =
-                  exists Field.typ ~compute:(fun () ->
+                let%map.Deferred vk_hash =
+                  exists_deferred Field.typ ~compute:(fun () ->
                       Lazy.force @@ Option.value_exn !vk_hash )
                 in
                 let { Pickles.Inductive_rule.previous_proof_statements
@@ -612,7 +633,7 @@ let compile :
                 let public_output, account_update_tree =
                   to_account_update account_update_under_construction
                 in
-                { previous_proof_statements
+                { Pickles.Inductive_rule.previous_proof_statements
                 ; public_output
                 ; auxiliary_output = (account_update_tree, auxiliary_output)
                 } )
@@ -622,7 +643,7 @@ let compile :
     go (choices ~self)
   in
   let tag, cache_handle, proof, provers =
-    Pickles.compile () ?self ?cache ?disk_keys ?override_wrap_domain
+    Pickles.compile_async () ?self ?cache ?disk_keys ?override_wrap_domain
       ~public_input:(Output Zkapp_statement.typ)
       ~auxiliary_typ:Typ.(Prover_value.typ () * auxiliary_typ)
       ~branches ~max_proofs_verified ~name ~constraint_constants ~choices
@@ -631,7 +652,7 @@ let compile :
     vk_hash :=
       Some
         ( lazy
-          ( Zkapp_account.digest_vk
+          ( Deferred.map ~f:Zkapp_account.digest_vk
           @@ Pickles.Side_loaded.Verification_key.of_compiled tag ) )
   in
   let provers =