Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nixpkgs nomination proposal #17

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Nixpkgs nomination proposal #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8f72db
Rename Nixpkgs committer delegation team -> Nixpkgs committer admins
Mic92 Jul 22, 2024
6630035
move nixpkgs applications to a seperate repository
Mic92 Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/github.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ There are many repositories, but these are some of the most important ones.

The Nix package collection and NixOS.

Currently there is an interim process for managing commit access, which is done by the Nixpkgs committer delegation team, whose processes are described [here](./nixpkgs-committers.md) and consists of these people:
Currently there is an interim process for managing commit access, which is done by the Nixpkgs committer admins, whose processes are described [here](./nixpkgs-committers.md) and consists of these people:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think github calls that role maintainers, so maybe "maintainer team"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be ideal if it would not clash with our maintainers in nixpkgs... We are running out of names.

- @Mic92
- @NickCao
- @jtojnar
Expand Down
14 changes: 9 additions & 5 deletions doc/nixpkgs-committers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
# Nixpkgs committers

There are over 200 Nixpkgs committers with access to merge any PR.
To become a Nixpkgs committer, you can apply [in this issue](https://github.com/NixOS/nixpkgs/issues/321665).

The [Nixpkgs committer delegation team](./github.md#nixpkgs) is given the responsibility and authority of changing the list of [Nixpkgs committers](https://github.com/orgs/NixOS/teams/nixpkgs-committers).
To become a Nixpkgs committer, you can apply by creating an issue [here](https://github.com/Mic92/nixpkgs-committers/issues/new/choose). (TODO: move this repository)
Committers should have their GitHub name/ID in the [maintainer-list](https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix).
This allows us to keep track of committers even if usernames are changed or accounts are deleted.

The [Nixpkgs committer admins](./github.md#nixpkgs) is given the responsibility and authority of changing the list of [Nixpkgs committers](https://github.com/orgs/NixOS/teams/nixpkgs-committers).

## Rules for changing the process for managing nixpkgs committer access

## Process
- The process must be publicly documented (this document)
- Any change to the process must be unanimously agreed upon by all delegation team members
- Any change in the list of committers must be publicly documented and agreed upon by all delegation team members
- Any change to the process must be unanimously agreed upon by all Nixpkgs committer admins.
- Any change in the list of committers must be publicly documented and agreed upon by all Nixpkgs committer admins.