Fix windows test failures currently observed in syevx, sygvx and getrf_large #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit investigates how the randomicity inherent with sampling the tests' input data might be interfering with their outcome.
jmachado-amd
requested review from
jzuniga-amd,
tfalders,
cgmb,
qjojo and
EdDAzevedo
as code owners
jmachado-amd
added
the
noOptimizations
Small bug fix to force the use of current thread id to generate seed.
jmachado-amd
changed the base branch from
develop
to
release-staging/rocm-rel-6.2
jmachado-amd
changed the base branch from
release-staging/rocm-rel-6.2
to
develop
Inspect seed choice during tests.
This commit is meant to facilitate debugging the tests for syevx/sygvx by printing, as part of those tests' outputs, hashes of the matrices used to store input, eigenvalues and eigenvectors (for both LAPACK and rocSOLVER).
… fix-windows-test-failures-syevx-sygvx-getrf_large-rocsolver3.26
…rf_large-rocsolver3.26
Change brittle comparison between number of computed eigenvalues for cases in which a value range is provided as input.
…rf_large-rocsolver3.26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to investigate and fix the current test failures observed in syevx, sygvx and getrf_large, which appear to be specific to rocSOLVER's windows builds.
An attempt will be made to keep the tests as close as possible to their current state.