Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix organization casing in docker workflow #271

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

evan-palmer
Copy link
Collaborator

Changes Made

This adds a fix for the organization case error that showed up in this build. I also re-enabled the scheduled builds.

Testing

Tested the workflow in this build

@evan-palmer
Copy link
Collaborator Author

I'm going to wait for that run to finish and retry the build to see if the cache worked @amarburg

@evan-palmer
Copy link
Collaborator Author

evan-palmer commented Aug 22, 2024

I forgot that this doesn't have the build stage in #241 and will (eventually) fail. Looking at the repo packages, it looks like the caching is working as expected though and a rolling-cache stage is being produced.

@amarburg
Copy link
Collaborator

Update line 133 as well:

*.cache-from=type=registry,ref=ghcr.io/${{ github.repository }}:cache-${{ matrix.ROS_DISTRO }}

It's (non-fatally) failing in CI here

Since it's a PR, it's only building for amd64 and should finish. Will let CI finish...

@evan-palmer
Copy link
Collaborator Author

Good catch. I missed that one

@evan-palmer
Copy link
Collaborator Author

evan-palmer commented Aug 22, 2024

Hypothetically, the PR build that you just triggered should be faster and using the cache from the Non PR build that I triggered earlier. The download activity on the rolling-cache image makes it seem like it is getting used.

@evan-palmer evan-palmer merged commit eaa8ec1 into main Aug 22, 2024
4 checks passed
@evan-palmer evan-palmer deleted the bug-invalid-org-case branch August 22, 2024 22:20
@evan-palmer evan-palmer added backport-iron Backport this PR to iron backport-humble Backport this PR to humble backport-jazzy Backport this PR to jazzy labels Aug 22, 2024
@evan-palmer evan-palmer self-assigned this Aug 22, 2024
mergify bot pushed a commit that referenced this pull request Aug 22, 2024
* Testing lowercase repo name for cache

* Remove dev branch from workflow and fix cron schedule

* Use lowercase repo for cache-from in PR build as well.

---------

Co-authored-by: Aaron Marburg <[email protected]>
(cherry picked from commit eaa8ec1)
mergify bot pushed a commit that referenced this pull request Aug 22, 2024
* Testing lowercase repo name for cache

* Remove dev branch from workflow and fix cron schedule

* Use lowercase repo for cache-from in PR build as well.

---------

Co-authored-by: Aaron Marburg <[email protected]>
(cherry picked from commit eaa8ec1)
mergify bot pushed a commit that referenced this pull request Aug 22, 2024
* Testing lowercase repo name for cache

* Remove dev branch from workflow and fix cron schedule

* Use lowercase repo for cache-from in PR build as well.

---------

Co-authored-by: Aaron Marburg <[email protected]>
(cherry picked from commit eaa8ec1)
evan-palmer added a commit that referenced this pull request Aug 23, 2024
* Testing lowercase repo name for cache

* Remove dev branch from workflow and fix cron schedule

* Use lowercase repo for cache-from in PR build as well.

---------

Co-authored-by: Aaron Marburg <[email protected]>
(cherry picked from commit eaa8ec1)

Co-authored-by: Evan Palmer <[email protected]>
evan-palmer added a commit that referenced this pull request Aug 23, 2024
* Testing lowercase repo name for cache

* Remove dev branch from workflow and fix cron schedule

* Use lowercase repo for cache-from in PR build as well.

---------

Co-authored-by: Aaron Marburg <[email protected]>
(cherry picked from commit eaa8ec1)

Co-authored-by: Evan Palmer <[email protected]>
evan-palmer added a commit that referenced this pull request Aug 23, 2024
* Testing lowercase repo name for cache

* Remove dev branch from workflow and fix cron schedule

* Use lowercase repo for cache-from in PR build as well.

---------

Co-authored-by: Aaron Marburg <[email protected]>
(cherry picked from commit eaa8ec1)

Co-authored-by: Evan Palmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Backport this PR to humble backport-iron Backport this PR to iron backport-jazzy Backport this PR to jazzy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants