✨ Support calling provider plugins. #16
guettlipr-lint.yml
on: pull_request_target
Lint Pull Request
2m 3s
Annotations
8 errors and 3 warnings
|
Lint Pull Request:
pkg/providerplugin/providerplugin.go#L29
paramTypeCombine: func(config *clusterstack.CsmctlConfig, clusterStackPath string, clusterStackReleaseDir string) error could be replaced with func(config *clusterstack.CsmctlConfig, clusterStackPath, clusterStackReleaseDir string) error (gocritic)
|
|
Lint Pull Request:
pkg/providerplugin/providerplugin.go#L36
G204: Subprocess launched with variable (gosec)
|
|
Lint Pull Request:
pkg/providerplugin/providerplugin.go#L18
error returned from external package is unwrapped: sig: func path/filepath.Abs(path string) (string, error) (wrapcheck)
|
|
Lint Pull Request:
pkg/providerplugin/providerplugin.go#L20
error returned from external package is unwrapped: sig: func path/filepath.Abs(path string) (string, error) (wrapcheck)
|
|
Lint Pull Request:
pkg/providerplugin/providerplugin.go#L39
error returned from external package is unwrapped: sig: func (*os/exec.Cmd).Run() error (wrapcheck)
|
|
Lint Pull Request:
pkg/cmd/create.go#L93
error returned from external package is unwrapped: sig: func github.com/SovereignCloudStack/csmctl/pkg/providerplugin.CheckProviderExecutable(config *github.com/SovereignCloudStack/csmctl/pkg/clusterstack.CsmctlConfig) (path string, err error) (wrapcheck)
|
|
Lint Pull Request:
pkg/cmd/create.go#L297
error returned from external package is unwrapped: sig: func github.com/SovereignCloudStack/csmctl/pkg/providerplugin.CreateNodeImages(config *github.com/SovereignCloudStack/csmctl/pkg/clusterstack.CsmctlConfig, clusterStackPath string, clusterStackReleaseDir string) error (wrapcheck)
|
|
Lint Pull Request
Process completed with exit code 2.
|
|
Lint Pull Request:
csmctldocker/csmctldocker_main.go#L1
package-comments: should have a package comment (revive)
|
|
Lint Pull Request:
pkg/providerplugin/providerplugin.go#L12
exported: exported function CheckProviderExecutable should have comment or be unexported (revive)
|
|
Lint Pull Request:
pkg/providerplugin/providerplugin.go#L1
package-comments: should have a package comment (revive)
|