Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Symfony 7 support #76

Merged
merged 2 commits into from
Nov 16, 2023
Merged

feat: Symfony 7 support #76

merged 2 commits into from
Nov 16, 2023

Conversation

kbond
Copy link
Contributor

@kbond kbond commented Oct 24, 2023

Adjusted the CI test matrix to add PHP 8.3 and only supported Symfony versions.

@kbond
Copy link
Contributor Author

kbond commented Oct 24, 2023

Ak, sorry @mbabker, I didn't see #75

@loic425
Copy link

loic425 commented Nov 8, 2023

@kbond Could we hope you merge it soon?
I'd like to start working on Symfony 7 support for Sylius packages and I need this support too.

@loic425 loic425 mentioned this pull request Nov 8, 2023
74 tasks
@Chris53897
Copy link
Contributor

I am not sure which persons have the right to merge or make a new release.
That is a question for @matthiasnoback

@kbond
Copy link
Contributor Author

kbond commented Nov 8, 2023

Friendly ping @stloyd, @xabbuh, @Nyholm. This PR and SymfonyTest/SymfonyDependencyInjectionTest#149 are blocking a bunch of bundles from being upgraded to support Symfony 7.

@loic425
Copy link

loic425 commented Nov 16, 2023

Another small and friendly ping to @stloyd, @xabbuh, @Nyholm.
RC1 is released and we all have a lot of work to do for Symfony 7 support :)
Thx a lot for all your work.

kbond and others added 2 commits November 16, 2023 08:58
Adjusted the CI test matrix to add PHP 8.3 and only supported Symfony versions
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit 3c8e756 into SymfonyTest:master Nov 16, 2023
13 checks passed
@Nyholm
Copy link
Member

Nyholm commented Nov 16, 2023

Can someone verify this on their project before we do a release?

@loic425
Copy link

loic425 commented Nov 16, 2023

Can someone verify this on their project before we do a release?

Hum I think we all use it via matthiasnoback/symfony-dependency-injection-test.
So I think we need this one to test it => SymfonyTest/SymfonyDependencyInjectionTest#149

@Nyholm
Copy link
Member

Nyholm commented Nov 16, 2023

Let's sneak this out then so CI pass on SymfonyTest/SymfonyDependencyInjectionTest#149

@Nyholm
Copy link
Member

Nyholm commented Nov 16, 2023

A bunch more PRs have been merged on https://github.com/SymfonyTest/SymfonyDependencyInjectionTest

We've dropped sf 4.4 and php 7.

Please test it out.

@kbond kbond deleted the sf7 branch November 16, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants