Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 7 support #149

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Symfony 7 support #149

merged 3 commits into from
Nov 16, 2023

Conversation

kbond
Copy link
Contributor

@kbond kbond commented Oct 24, 2023 •
edited
Loading

Requires SymfonyTest/SymfonyConfigTest#76

Also added dev to the composer.json keywords. This will prompt a warning if someone tries to install without --dev.

@kbond
Copy link
Contributor Author

kbond commented Oct 24, 2023

Should we cleanup the CI matrix a bit and only test on supported Symfony versions?

@Chris53897 Chris53897 mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 2, 2023
Merged
Merged
Merged
@HeahDude
Copy link

SymfonyTest/SymfonyConfigTest#76 has been merged.

@loic425 loic425 mentioned this pull request Nov 16, 2023
Closed
74 tasks
Nyholm
Nyholm reviewed Nov 16, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@Nyholm Nyholm changed the title feat: Symfony 7 support Symfony 7 support, Drop SF 4.4 and PHP 7 Nov 16, 2023
@Nyholm Nyholm changed the title Symfony 7 support, Drop SF 4.4 and PHP 7 Symfony 7 support Nov 16, 2023
Nyholm
Nyholm approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I messed around a lot to try to make the test pass. I rebased this on master after #148 was merged.

@Nyholm Nyholm merged commit 8ae4914 into SymfonyTest:master Nov 16, 2023
13 checks passed
@kbond kbond deleted the sf7 branch November 16, 2023 11:31
@VincentLanglet
Copy link

Hi @Nyholm, is something missing to release the 5.0 version ?

This would help other libraries adding support for SF7 :)

Big thanks.

@Nyholm
Copy link
Member

Nyholm commented Nov 22, 2023

No, not that Im aware of.
Does main branch work for you when you testing with your libraries?

@VincentLanglet
Copy link

Does main branch work for you when you testing with your libraries?

Yes, with dev-master as 5.0 it's work on sonata-project/twig-extensions#392

@Nyholm
Copy link
Member

Nyholm commented Nov 22, 2023

Lovely. Thank you for testing. Let's tag it =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbond @HeahDude @VincentLanglet @Nyholm