Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

did read and init for MS5611 #154

Merged
merged 2 commits into from
Oct 16, 2024
Merged

did read and init for MS5611 #154

merged 2 commits into from
Oct 16, 2024

Conversation

Azhanzz
Copy link
Contributor

@Azhanzz Azhanzz commented Sep 30, 2024

No description provided.

@Azhanzz
Copy link
Contributor Author

Azhanzz commented Sep 30, 2024

Used this library: https://www.arduino.cc/reference/en/libraries/ms5611/

DrewBrandt
DrewBrandt requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@DrewBrandt DrewBrandt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only minor changes. Was it hard to implement? How was working with MMFS (even for just this small thing?)

edit: Did you not need to modify the platformio.ini to add the dependency?

Spaceport/Code/Teensy-Based Avionics/src/Sensors/MS5611.cpp Outdated Show resolved Hide resolved
Spaceport/Code/Teensy-Based Avionics/src/Sensors/MS5611.h Outdated Show resolved Hide resolved
@DrewBrandt DrewBrandt linked an issue Oct 1, 2024 that may be closed by this pull request
MS5611 (Barometer #1) Implementation #146
Closed
@DrewBrandt DrewBrandt self-requested a review October 16, 2024 02:39
@varun-un varun-un merged commit 6f87f6c into Terrapin-Rocket-Team:main Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrewBrandt DrewBrandt DrewBrandt approved these changes

Assignees

@Azhanzz Azhanzz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MS5611 (Barometer #1) Implementation
3 participants
@Azhanzz @DrewBrandt @varun-un