Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Don't transform the HashAggregate to CometHashAggregate if Comet shuffle is disabled #991

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Oct 1, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@mbutrovich
Copy link
Contributor

mbutrovich commented Oct 1, 2024

Do the benchmarks in

need to be updated? Part of my exploration today (that motivates this PR) is that the CometBaseBenchmark and by extension the CometAggregateBenchmark does not set Comet at the shuffle manager. CometExecBenchmark does set the shuffle manager:

@viirya
Copy link
Member Author

viirya commented Oct 1, 2024

Yea, we should update CometAggregateBenchmarks to enable shuffle for it.

@mbutrovich
Copy link
Contributor

This should help a lot for #987! Thanks for the quick fix!

@viirya viirya merged commit 18150fb into apache:main Oct 1, 2024
75 checks passed
@viirya
Copy link
Member Author

viirya commented Oct 1, 2024

Thanks @kazuyukitanimura @mbutrovich

@viirya viirya deleted the disallow_final_object_hash branch October 1, 2024 23:15
@viirya viirya restored the disallow_final_object_hash branch October 1, 2024 23:15
@viirya viirya deleted the disallow_final_object_hash branch October 1, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants