Add support for configuring a custom error factory for a service #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
force-pushed
the
custom_error_factory
branch
from
6e95a6c
to
ffaeb94
Compare
jderusse
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Amazon Incentives API implements a protocol compatible with the rest-xml AWS protocol except for the representation of errors (they also provide a JSON protocol which is compatible with the rest-json AWS protocol except the representation of errors but with a crappy representation of ThrottlingException that only returns
{"message": "Rate exceeded"}without even a proper 429 status code).This adds support for an optional
error-factoryentry in the manifest file allowing to force a specific implementation of the error factory. The provided class is still expected to have a constructor with no arguments like all the core factories due to the generated code.