Remove the internal tag from Core classes used in other packages #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
commented
Jun 30, 2023
| @@ -4,9 +4,6 @@ | |||
|
|
|||
| use Symfony\Contracts\HttpClient\ResponseInterface; | |||
|
|
|||
| /** | |||
| * @internal | |||
There was a problem hiding this comment.
I made the trait non-final because it is the only implementation of createFromResponse and so it might be useful for #1485 when implementing an error factory internally.
Alternatively, we could remove createFromResponse from the interface, inlining the extraction of the createFromContent arguments. A class with a custom logic in createFromContent is incompatible with the chain factory anyway because the chain factory performs this extraction on its own and then calls only createFromContent
| @@ -8,8 +8,6 @@ | |||
| * Convert an iterator into a Stream. | |||
| * | |||
| * @author Jérémy Derussé <[email protected]> | |||
| * | |||
| * @internal | |||
There was a problem hiding this comment.
Of all these stream classes, this IterableStream could stay internal if the S3 signer uses the factory instead. but other special streams can only be used directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes and interfaces from Core used in other packages should not be marked as
@internalas they need to be covered by BC.For a bunch of them, I made them final (when they were not already final) so that we don't need to support the use case of inheritance.