refactor: Refactor eligibility bar component #1211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onent Refactored TeeEligibilityCriteriaBar to TeeEligibilityBar and moved it to a new path. Added a new ProgramEligibilityBar component to display program eligibility details. Updated various components and typings to integrate the new eligibility bar.
# Conflicts: # apps/web/src/components/program/detail/ProgramDetail.vue
…y checks This commit introduces the 'eligibility' field to the ProgramType interface within programTypes.ts. Additionally, it refactors ProgramEligibilityBar.vue to directly use this new field, streamlining the eligibility check logic and reducing code complexity.
Modified the type of `url` in `TeeEligibilityBarLink` from `string` to `string | RouteName`. This ensures that type casting is correctly applied when using `getRouteToUrl`.
…text Removed redundant Breakpoint import and added labelMobile property to handle different text for mobile views in ProgramEligibilityBar. This change improves readability and maintains appropriate labeling across different devices.
Changed the ID from 'eligibility-criteria-bar' to 'eligibility-bar' for consistency. Updated label rendering to use a method for dynamic content. Improved scroll function to account for top bar height during navigation.
This change eliminates an unnecessary console.log statement used for debugging purposes. Keeping the log statement is redundant and could affect performance or clutter the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: PR partielle ne traitant que la question du composant TeeEligibilityBar. Dépend au moins des modifs de la PR #1217
###Résumé :
Cette pull request introduit plusieurs modifications pour améliorer la fonctionnalité d'éligibilité dans les composants de détail du programme. Les mises à jour principales incluent l'ajout d'un nouveau composant
ProgramEligibilityBar, la suppression de l'ancien composantTeeEligibilityCriteriaBar, et des mises à jour des types de données du programme pour inclure les informations d'éligibilité.Améliorations de la fonctionnalité d'éligibilité :
Nouveau composant de barre d'éligibilité :
ProgramEligibilityBarpour afficher les messages et les liens d'éligibilité en fonction du statut d'éligibilité du programme. (apps/web/src/components/program/detail/ProgramEligibilityBar.vue, apps/web/src/components/program/detail/ProgramEligibilityBar.vueR1-R65)ProgramEligibilityBardansProgramHeader.vue. (apps/web/src/components/program/detail/ProgramHeader.vue, apps/web/src/components/program/detail/ProgramHeader.vueR2-L9)Suppression de l'ancienne barre de critères d'éligibilité :
TeeEligibilityCriteriaBaret de ses références dans divers fichiers. (apps/web/src/components/program/eligibilityCriteria/TeeEligibilityCriteriaBar.vue, [1];apps/web/src/components/project/details/ProjectHeader.vue, [2]Mises à jour des types de données du programme :
eligibilityà l'interfaceProgramData. (apps/web/src/types/program/programTypes.ts, apps/web/src/types/program/programTypes.tsR35)ProgramEligibilityTypepour représenter les différents statuts d'éligibilité. (libs/data/src/program/types/shared.ts, libs/data/src/program/types/shared.tsR22-R27)Modifications diverses :
Groupe d'accordéon pour les détails du programme :
apps/web/src/components/program/detail/ProgramDetail.vue, [1] [2]Mise à jour de l'utilitaire de défilement :
apps/web/src/utils/scroll.ts, apps/web/src/utils/scroll.tsL5-R5)Ces changements améliorent collectivement l'expérience utilisateur en fournissant des informations d'éligibilité claires et dynamiques directement dans les détails du programme.
App test :
https://tee-preprod-pr1211.osc-fr1.scalingo.io/
Linked issue :
close #1103