Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor eligibility bar component #1211

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Commits on Oct 11, 2024

  1. refactor: Refactor eligibility bar and add ProgramEligibilityBar comp…

    …onent
    
    Refactored TeeEligibilityCriteriaBar to TeeEligibilityBar and moved it to a new path. Added a new ProgramEligibilityBar component to display program eligibility details. Updated various components and typings to integrate the new eligibility bar.
    dolemoine committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    37989a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'main' into feat/partial-eligibility-topbar

    # Conflicts:
    #	apps/web/src/components/program/detail/ProgramDetail.vue
    dolemoine committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9c0f5a7 View commit details
    Browse the repository at this point in the history
  2. feat: Add 'eligibility' field to programTypes and simplify eligibilit…

    …y checks
    
    This commit introduces the 'eligibility' field to the ProgramType interface within programTypes.ts. Additionally, it refactors ProgramEligibilityBar.vue to directly use this new field, streamlining the eligibility check logic and reducing code complexity.
    dolemoine committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    88ed9f3 View commit details
    Browse the repository at this point in the history
  3. refactor: Update type annotation for link.url in TeeEligibilityBar

    Modified the type of `url` in `TeeEligibilityBarLink` from `string` to `string | RouteName`. This ensures that type casting is correctly applied when using `getRouteToUrl`.
    dolemoine committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0754bfa View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. refactor: Refactor eligibility bar labels to support mobile-specific …

    …text
    
    Removed redundant Breakpoint import and added labelMobile property to handle different text for mobile views in ProgramEligibilityBar. This change improves readability and maintains appropriate labeling across different devices.
    dolemoine committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ce55e42 View commit details
    Browse the repository at this point in the history
  2. refactor: Rename eligibility bar ID and update label rendering

    Changed the ID from 'eligibility-criteria-bar' to 'eligibility-bar' for consistency. Updated label rendering to use a method for dynamic content. Improved scroll function to account for top bar height during navigation.
    dolemoine committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    1e77ac1 View commit details
    Browse the repository at this point in the history
  3. refactor: Remove console log from filterPrograms.ts

    This change eliminates an unnecessary console.log statement used for debugging purposes. Keeping the log statement is redundant and could affect performance or clutter the output.
    dolemoine committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    399019b View commit details
    Browse the repository at this point in the history