fix(accessibility): skip uploadsManager in voiceover if not visible #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
joshmarnold
approved these changes
Aug 4, 2023
tjuanitas
reviewed
Aug 4, 2023
| @@ -3,6 +3,7 @@ | |||
| .be.bcu-uploads-manager-container { | |||
| position: fixed; | |||
| bottom: 0; | |||
| display: none; | |||
| width: 100%; | |||
| max-height: 0; | |||
| transition: max-height .5s; | |||
There was a problem hiding this comment.
there's a transition on this class, does it still work? I think there are conflicts when trying to animate and update the display property at the same time (I think some issues with visibility too)
There was a problem hiding this comment.
@tjuanitas It still works for me on Chrome and Safari
Screen.Recording.2023-08-07.at.10.16.06.mov
There was a problem hiding this comment.
that transition occurs when toggling bcu-is-expanded which happens after display: initial is already applied. you'll want to test toggling bcu-is-visible which handles the transition between display: none -> display: initial. this will happen on drag-or-drop or when a file is uploaded
uploader-transition.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change voiceover is detecting uploadManager even if it is not visible on the screen.