Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(accessibility): skip uploadsManager in voiceover if not visible #3379

Closed
wants to merge 2 commits into from
Closed

fix(accessibility): skip uploadsManager in voiceover if not visible #3379

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cafef60
fix: skip uploadsManager in voiceover if not visible
bkepka-box Aug 4, 2023
2b05b3f
fix: css variable reorder
bkepka-box Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/elements/content-uploader/UploadsManager.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
.be.bcu-uploads-manager-container {
position: fixed;
bottom: 0;
display: none;
width: 100%;
max-height: 0;
transition: max-height .5s;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a transition on this class, does it still work? I think there are conflicts when trying to animate and update the display property at the same time (I think some issues with visibility too)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjuanitas It still works for me on Chrome and Safari

Screen.Recording.2023-08-07.at.10.16.06.mov

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that transition occurs when toggling bcu-is-expanded which happens after display: initial is already applied. you'll want to test toggling bcu-is-visible which handles the transition between display: none -> display: initial. this will happen on drag-or-drop or when a file is uploaded

uploader-transition.mov

Expand All @@ -22,6 +23,7 @@
}

&.bcu-is-visible {
display: initial;
max-height: 60px;
}

Expand Down
Loading