-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gtfs time zone handling #2457
Merged
Merged
Gtfs time zone handling #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
lauriemerrell
force-pushed
the
gtfs-time-zone-handling
branch
2 times, most recently
from
April 13, 2023 01:42
2eaef74
to
443f6a2
Compare
lauriemerrell
force-pushed
the
gtfs-time-zone-handling
branch
from
April 18, 2023 20:28
b2ddbba
to
6d3ab2a
Compare
This was referenced Apr 20, 2023
lauriemerrell
force-pushed
the
gtfs-time-zone-handling
branch
from
April 20, 2023 18:56
a2e8769
to
15d2dc8
Compare
6 tasks
lauriemerrell
requested review from
atvaccaro and
SorenSpicknall
as code owners
April 21, 2023 18:29
This was referenced Apr 21, 2023
lauriemerrell
force-pushed
the
gtfs-time-zone-handling
branch
from
April 24, 2023 13:52
9906874
to
1148ea7
Compare
atvaccaro
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comprehensive docs 📖
warehouse/models/intermediate/gtfs/int_gtfs_schedule__stop_times_grouped.sql
Show resolved
Hide resolved
atvaccaro
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty ty
5 tasks
lauriemerrell
pushed a commit
that referenced
this pull request
Apr 24, 2023
5 tasks
lauriemerrell
pushed a commit
that referenced
this pull request
Apr 28, 2023
lauriemerrell
pushed a commit
that referenced
this pull request
May 5, 2023
lauriemerrell
added a commit
that referenced
this pull request
May 8, 2023
* add intervals and seconds to dim frequencies * wip -- trip summary * update stop times after #2457 merged * working expanded frequencies, wip yaml * clean up yaml * clean up comments * update yaml and rename some cols * cleanup * frequency based trips in stop times grouped * frequency based trips in fct daily scheduled trips * add frequencies to daily stops * remove erroneous comment
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds timezone localization information to GTFS schedule data:
trip_start_timezone
andtrip_end_timezone
toint_gtfs_schedule__stop_times_grouped
andfct_daily_scheduled_trips
fct_daily_scheduled_trips
service_date
as the date summary level for stops, shapes, and daily schedule service summary per discussion in Slack with @tiffanychu90 and @edasmalchiservice_date
should not be cast directly to a timestamp (i.e. midnight); it is explicitly defined as starting from noon minus 12 hours to handle daylight savingsFollow-ups:
feed_timezone
field) -- can do immediately after merge:poetry run dbt run --full-refresh -s dim_schedule_feeds+,config.materialized:incremental --exclude fct_daily_rt_feed_files fct_hourly_rt_feed_files fct_hourly_rt_feed_files_success
activity_date
toservice_date
change in organization service summary reports#245activity_date
toservice_date
change in organization service summary reports#245Resolves #2348
Type of change
How has this been tested?
Have run & tested affected tables locally. Looked specifically at daylight savings day service to confirm new implementation works.
Screenshots (optional)