issue_139: check invalid url #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuanngocnguyen
force-pushed
the
issue139_invalid_url
branch
2 times, most recently
from
9ee2d2f
to
c330723
Compare
|
Hi @brendanheywood, I have created a patch for invalid url. Would you please have a look once you have some time? Thanks |
classes/robot/crawler.php
Outdated
| @@ -286,6 +286,10 @@ public function mark_for_crawl($baseurl, $url, $courseid = null, $priority = TOO | |||
|
|
|||
| $url = $this->absolute_url($baseurl, $url); | |||
|
|
|||
| if (filter_var($url, FILTER_VALIDATE_URL) === false) { | |||
There was a problem hiding this comment.
This should probably use the moodle libs instead:
clean_param($url, PARAM_URL);
tuanngocnguyen
force-pushed
the
issue139_invalid_url
branch
2 times, most recently
from
3b7e23b
to
ea1cc68
Compare
tuanngocnguyen
force-pushed
the
issue139_invalid_url
branch
from
ea1cc68
to
e125268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #139