Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default FileExporter file_mode to a #887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gjoseph92
Copy link

The current default, w+, overwrites the contents of the file on the first write. Since emit opens and writes to the file every time it's called, this effectively rewrites the file on every emit. Perhaps this is intended behavior, but it took me a while to understand why there was only one span written to my file, even though I could tell multiple were being emitted. I didn't have my Python file mode tables memorized, so at first glance w+ sounded like "write mode, + for append", and I overlooked it while debugging.

I think a (append) would be a more intuitive default.

The current default, `w+`, overwrites the contents of the file on the first write. Since `emit` opens and writes to the file every time it's called, this effectively rewrites the file on every `emit`. Perhaps this is intended behavior, but it took me a while to understand why there was only one span written to my file, even though I could tell multiple were being emitted. I didn't have my [Python file mode tables](https://docs.python.org/3/library/functions.html#open) memorized, so at first glance `w+` sounded like "write mode, + for append", and I overlooked it while debugging.

I think `a` (append) would be a more intuitive default.
@gjoseph92 gjoseph92 requested review from c24t, reyang, songy23 and a team as code owners April 30, 2020 00:48
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@gjoseph92
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants