Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default FileExporter file_mode to a #887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Default FileExporter file_mode to a #887

wants to merge 1 commit into from

Commits on Apr 30, 2020

  1. Default FileExporter file_mode to a 

    The current default, `w+`, overwrites the contents of the file on the first write. Since `emit` opens and writes to the file every time it's called, this effectively rewrites the file on every `emit`. Perhaps this is intended behavior, but it took me a while to understand why there was only one span written to my file, even though I could tell multiple were being emitted. I didn't have my [Python file mode tables](https://docs.python.org/3/library/functions.html#open) memorized, so at first glance `w+` sounded like "write mode, + for append", and I overlooked it while debugging.

I think `a` (append) would be a more intuitive default.
    @gjoseph92
    gjoseph92 authored Apr 30, 2020
    Configuration menu
    Copy the full SHA
    ad65114 View commit details
    Browse the repository at this point in the history