fix: add superagent types as prod dependency #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We expose superagent's types in our own types, so this should be a production dependency. Otherwise, we will cause errors in the typescript builds of consumers (unless they skip lib check). It does mean we add an unnecessary dependency for non-ts people, but there's not any simple way around that.
|
Thank you! |
I think we do skip lib check... the issue is that our own project doesn't typecheck because we're relying on types that we couldn't find in our dependency tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expose superagent's types in our own types, so this should be a production dependency. Otherwise, we will cause errors in the typescript builds of consumers (unless they skip lib check).
It does mean we add an unnecessary dependency for non-ts people, but there's not any simple way around that.
Fixes #346