-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VolumeSnapshot backup capability #335
base: main
Are you sure you want to change the base?
Conversation
This fixes issues with using volumeSnapshots where the Cluster object didn't have an appropriate [VolumeSnapshotConfiguration](https://cloudnative-pg.io/documentation/1.23/cloudnative-pg.v1/#postgresql-cnpg-io-v1-VolumeSnapshotConfiguration) block. It also prevents the chart complaining that we haven't set azure/s3/google specific variables when we have chosen to use VolumeSnapshots. Signed-off-by: Cam Smith <[email protected]>
Signed-off-by: Cam Smith <[email protected]>
This looks pretty good! Would you have the time to add the Recovery from VolumeSnapshots functionality as well? It wouldn't want to add this as a backup method without adding a recovery path, as that could potentially make it more difficult to recover from. |
Signed-off-by: Cam Smith <[email protected]>
Thanks @itay-grudev! I've added support for recovery from snapshots and tested this in a GKE environment. The recovery config docs also mention being able to use a PVC as a recovery mechanism with the same block on the cluster, but that failed when I tested it, otherwise I would have added that too. It might be a nice to have when that capability stabilises in the operator. Please let me know if there's anything else that could make this better. |
Hi @itay-grudev please let me know what blockers if any there are to merging, we are really keen to start using this when it is released :) |
I not think force user to decide between s3 and snapshot is good idea actually. Provider allow to utilize both S3 and snapshots, why we in Helm should cut off this capabilities, I see this option as: #359 |
Hi @dragoangel, I like your PR a lot. Whatever the maintainers prefer I am happy with, I just really want some volume snapshot capability. I've posted a review on your PR with two suggested changes. @itay-grudev please feel free to close this PR if you are going to merge #359 . |
Hi this is my first contribution so please let me know if I have missed anything.
This PR fixes two issues with VolumeSnapshots for backups:
This is achieved by establishing 'volumeSnapshot' as a
backups.provider
.There are no breaking changes.
Fixes #334