-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cluster): Add support for replication and import, volumeSnapshot recovery #359
base: main
Are you sure you want to change the base?
feat(cluster): Add support for replication and import, volumeSnapshot recovery #359
Conversation
0c2a984
to
6a40b52
Compare
@itay-grudev I also have strong feeling that better put all cloud related settings under dedicated level, so everything starting from From my view it will simplify reading Also have a question: rotation applies to snapshots as well, right? And if yes - then if we choose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this solution a lot, this addresses issue #334 differently than #335 (my own PR). I don't mind whichever solution the maintainers prefer, so long as we get this capability :)
I tested this today and it worked perfectly with the two attached changes.
This PR needs
- update to values in
README.md
- an example values file for backup and restore
Hi @cam-at-tactiq , yes I know, yesterday I was created couple of functional PRs and almost in every of them need to do it, thanks for heads up. I will add them today, yesterday was too much exchasted. For this PR also I need a bit feedback on questions I commented :) If we will decide move inside sub path of objectStorage I will also need to change all examples that use them and tests 🙂 One minus of my PR is breaking change, I think it will be merged not now, as it would require major version bump which @itay-grudev would like not to do right now. The good thing about charts that you can maintain your own fork without even hosting own helm registry by using a dependency |
I decided to move everything under dedicated section, it greatly improves readability, plus having |
6951a96
to
573c2cf
Compare
2145416
to
3c30ef2
Compare
d20d80a
to
10fe5cc
Compare
10fe5cc
to
c6d2621
Compare
Hi @cam-at-tactiq, if you have some time - could you please test my PR? From my tests everything works good, but second-third view wouldn't be out of place. Thank you in advance. Hi @itay-grudev, I not done tests via If you have any questions or propositions about this PR, do not hesitate ping me in Slack 😉. I understand it is big, and will require quite time to review, and yes it is BREAKING CHANGE |
c6d2621
to
0d1da10
Compare
0d1da10
to
37a4e60
Compare
… recovery Signed-off-by: Dmitriy Alekseev <[email protected]>
37a4e60
to
be3c889
Compare
Signed-off-by: Dmitriy Alekseev <[email protected]>
This PR adds functionality for:
Breaking changes:
.Values.backups.enabled
and set.Values.backups.objectStorage.providers
to""
. Expect from users to set desired provider and configure it under.Values.backups.objectStorage.providersSettings
, otherwise cloud backups will not work. Settings related toobjectStorage
was moved from.Values.backups
under.Values.backups.objectStorage
so they are not tangled withvolumeSnapshot
settingsrecovery
is working. As we have a lot of recovery methods, user should choose firstmethod
and configure it undermethodSettings.<chosen-method>
.Also this PR provides other functional improvements:
.Values.backups.<chosen-method>
, describe the necessary checks in_helper.tpl
and add a renderer in CloudNative-PG CR already reliably checked variables. Then we usually will need restore from this method, so we will add.Values.recover.methodSettings.<chosen-method>
and this will automatically extend options for.Values.recover.method
, as it not hardcoded, but checked dynamically from.Values.recover.methodSettings
. We will also need to add necessary checks in_helper.tpl
and add a renderer in CloudNative-PG CR for restore section.