WIP Add source facets #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
DougBurke
force-pushed
the
add-source-facets
branch
4 times, most recently
from
7e383cc
to
63fec9e
Compare
Allow the source display to be toggled: that is, subset the selected set of sources. The UI for this simple faceting is confusing, and the choice of options are a) not well labelled (needs to be re-written before release) b) very limited c) not used in ADQL queries The subset is reflected in the 'plot properties' code. Note that filtering the sources (either by turning off or on a toggle) invalidates the "nearest source" and "selected source" window, so they are removed if displayed. This is not always needed, but is the easiest to implement and probably explain.
DougBurke
force-pushed
the
add-source-facets
branch
from
63fec9e
to
1d1a9ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can we learn anything by sub-setting the selected sources?
The UX here is less-than-stellar