Player components and Comms extensions #144

menduz · 2023-05-04T15:05:52Z

No description provided.

github-actions · 2023-05-04T15:06:47Z

Test this pull request

The @dcl/protocol package can be tested in scenes by running

npm install "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-5590510582.commit-7432974.tgz"

Update this package to test in the SDK by running

make update-protocol UPDATE_PROTOCOL_VERSION=https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-5590510582.commit-7432974.tgz
make build update-snapshots

proto/decentraland/sdk/components/avatar_customization.proto

proto/decentraland/sdk/components/player_identity_data.proto

Squashed commit of the following: commit 8a62a78 Author: Lean Mendoza <[email protected]> Date: Wed May 10 16:03:27 2023 -0300 update @dcl/ts-proto commit c3bd264 Merge: 2ebeae0 dce1b9e Author: Lean Mendoza <[email protected]> Date: Tue May 9 08:55:46 2023 -0300 Merge remote-tracking branch 'origin/refactor/sdk6-component-serialization' into refactor/sdk6-component-serialization commit dce1b9e Author: Leandro Mendoza <[email protected]> Date: Wed May 3 12:06:34 2023 -0300 change Color4 for ecs6 commit 8d58b02 Merge: 438eb7d 286ee57 Author: Lean Mendoza <[email protected]> Date: Wed May 3 08:59:15 2023 -0300 Merge branch 'main' into refactor/sdk6-component-serialization commit 438eb7d Author: Leandro Mendoza <[email protected]> Date: Wed May 3 08:53:02 2023 -0300 fix albedoColor4 commit 84aa511 Author: Leandro Mendoza <[email protected]> Date: Mon May 1 13:59:05 2023 -0300 fix makefile commit c8491e5 Merge: 3f5df94 8b14b40 Author: Lean Mendoza <[email protected]> Date: Mon May 1 12:55:42 2023 -0300 Merge branch 'main' into refactor/sdk6-component-serialization commit 3f5df94 Author: Leandro Mendoza <[email protected]> Date: Mon May 1 12:42:59 2023 -0300 fix ts-proto library commit b36a879 Author: Leandro Mendoza <[email protected]> Date: Thu Apr 27 10:09:00 2023 -0300 workaround commit fdbfdd2 Author: Leandro Mendoza <[email protected]> Date: Thu Apr 27 10:06:00 2023 -0300 add missing components (interface) commit 228e128 Author: Leandro Mendoza <[email protected]> Date: Thu Apr 27 09:54:26 2023 -0300 add missing components commit a365920 Merge: c734932 8494b7b Author: Lean Mendoza <[email protected]> Date: Wed Apr 26 11:30:25 2023 -0300 Merge branch 'main' into refactor/sdk6-component-serialization commit c734932 Author: Leandro Mendoza <[email protected]> Date: Wed Apr 26 09:45:33 2023 -0300 fix ui input text commit 9a9733f Merge: ea1a486 32cf19f Author: Lean Mendoza <[email protected]> Date: Mon Apr 24 10:56:39 2023 -0300 Merge branch 'main' into refactor/sdk6-component-serialization commit ea1a486 Author: Lean Mendoza <[email protected]> Date: Mon Apr 24 10:55:01 2023 -0300 missing properties commit a699a41 Author: Lean Mendoza <[email protected]> Date: Mon Apr 24 09:48:09 2023 -0300 missing properties commit 2e9e708 Merge: fa08d1b 3dc0529 Author: Lean Mendoza <[email protected]> Date: Mon Apr 24 09:27:23 2023 -0300 Merge branch 'main' into refactor/sdk6-component-serialization commit fa08d1b Author: Leandro Mendoza <[email protected]> Date: Wed Apr 19 21:52:39 2023 -0300 fix uivalues commit 6e9b6d4 Author: Leandro Mendoza <[email protected]> Date: Tue Apr 18 16:41:16 2023 -0300 add ray query commit 32fb363 Merge: 7cd2ae7 c48ea0a Author: Lean Mendoza <[email protected]> Date: Tue Apr 18 12:05:36 2023 -0300 Merge branch 'main' into refactor/sdk6-component-serialization commit 7cd2ae7 Author: Leandro Mendoza <[email protected]> Date: Tue Apr 18 09:25:08 2023 -0300 make all optional commit efcdb98 Author: Leandro Mendoza <[email protected]> Date: Mon Apr 17 14:32:40 2023 -0300 change to oneof commit 2bf3784 Author: Leandro Mendoza <[email protected]> Date: Mon Apr 17 10:41:55 2023 -0300 change file names commit 4e12942 Author: Leandro Mendoza <[email protected]> Date: Mon Apr 17 09:45:08 2023 -0300 refactor: move engine_interface and add components data

This reverts commit 9a568b1.

This reverts commit 4b98e1a. Co-authored-by: jmoguilevsky <[email protected]>

slezica

Fantastic work 🎉 Having these messages clears the way for very interesting features!

slezica · 2023-05-19T19:15:04Z

proto/decentraland/kernel/comms/rfc4/comms.proto

@@ -14,9 +14,45 @@ message Packet {
    Chat chat = 5;
    Scene scene = 6;
    Voice voice = 7;
+    SdkComponent sdk_component = 8;
+    CustomSignal signal = 9;


I may have gone overboard with this comment. Sorry! 😅

I recommend we change the names to Component and Custom.

My thoughts:

Rationale for Component

I think we should avoid having hard references to the SDK at the protocol layer. It's fine for comments, but a variable name feels like conceptually breaking through the layers 👊 .

I don't think the word Component needs clarification. The meaning is very established in our terminology, and has been for a long while.

While Sdk does additionally imply that the Component is standard, that's a reasonable assumption of any message in the protocol unless otherwise specified.

Rationale for Custom

The term Signal is associated with semantics that don't quite fit here.

Custom, removing Signal, matches the style of the other names (e.g. we don't have ChatMessage or VoiceSample) and is explicit about the purpose of the field: this is for unspecified stuff.

I can't think of other places where we'd reuse this concept of Signal. If this is going to be the only case, I don't think we should introduce it.

slezica · 2023-05-19T19:16:21Z

proto/decentraland/kernel/comms/rfc4/comms.proto

+// custom implementation-dependant signals.
+//
+// It is recommended that signal names are namespaced to avoid collisions. For
+// example, a signal to request a profile could be named "decentraland.profile-request.v1"


This recommendation is super reasonable. Would it be a good idea to enforce it by having a namespace field?

Edit or maybe specify that there must be at least 1 standardized separator (., /, whatever) in the string

slezica · 2023-05-19T19:17:15Z

proto/decentraland/kernel/comms/rfc4/comms.proto

+message SdkComponent {
+  uint32 component_id = 1;
+  bytes data = 2;
+  uint32 timestamp = 3;


It would be nice to add some additional description for the timestamp field, as with the other two. It's unclear in this context (Components sent over comms) whether this is a Lamport timestamp, a Unix timestamp, or some other time-like value. The same name is used with a float type for milliseconds in Position, and there's a nice comment there 😄

proto/decentraland/kernel/comms/rfc4/comms.proto

slezica · 2023-05-19T19:31:02Z

proto/decentraland/sdk/components/avatar_customization.proto

+option (common.ecs_component_id) = 1087;
+
+// AvatarCustomizations sets all modifiers over the avatar's apparence. This 
+message PBAvatarCustomization {


The word Customization is a little long. How about Mods, for modifiers? I'm not sure, nothing better is coming to mind right now.

proto/decentraland/sdk/components/avatar_emote_command.proto

proto/decentraland/sdk/components/avatar_customization.proto

proto/decentraland/sdk/components/tween.proto

slezica · 2023-05-19T19:45:49Z

proto/decentraland/sdk/components/tween.proto

+    TF_EASE_IN_OUT_ELASTIC = 28;
+    TF_EASE_IN_BOUNCE = 29;
+    TF_EASE_IN_OUT_BOUNCE = 30;
+    TF_EASE_OUT_BOUNCE = 31;


I can't wait to see a demo scene full of things animating with weird accelerations 🎉

leanmendoza · 2024-05-10T15:35:09Z

some of the features were tackled here

menduz added 4 commits May 10, 2023 18:44

add sdk commands for comms

37eac37

remove unused duplicated file

3a3d11b

wip

49b7f43

fix id

b8d55a5

menduz force-pushed the comms branch from abe8d8b to b8d55a5 Compare May 10, 2023 22:02

robtfm reviewed May 10, 2023

View reviewed changes

proto/decentraland/sdk/components/avatar_customization.proto Outdated Show resolved Hide resolved

robtfm reviewed May 10, 2023

View reviewed changes

proto/decentraland/sdk/components/player_identity_data.proto Show resolved Hide resolved

menduz and others added 13 commits May 11, 2023 09:09

fix id

a85bd7d

fix color3

4ed3ee9

add more instructions to PR build

ae4e574

feat: add errors in social service response (#145)

f3c10ae

add skybox textures

523a10f

Revert "feat: add errors in social service response (#145)" (#148)

908f271

This reverts commit 9a568b1.

chore: add note for introducing breaking changes (#147)

86bc6c2

chore: nft shape urn update (#146)

82bab20

feat: add errors in social service response (#145) (#149)

ba7bcad

This reverts commit 4b98e1a. Co-authored-by: jmoguilevsky <[email protected]>

add info

9780e3d

extend comms

0ec081e

Merge branch 'main' into comms

23fe6bd

hugoArregui previously approved these changes May 19, 2023

View reviewed changes

add tween component

c10dba3

menduz dismissed hugoArregui’s stale review via c10dba3 May 19, 2023 18:26

menduz added 2 commits May 19, 2023 15:31

add clarifications

4480d61

wip

3d87f8b

slezica reviewed May 19, 2023

View reviewed changes

menduz added 3 commits May 19, 2023 16:59

wip

c09d710

better comments

d2f1b84

fix build

f2a6d0b

menduz changed the title ~~add sdk commands for comms~~ Player components and Comms extensions May 22, 2023

menduz and others added 8 commits May 22, 2023 13:55

add comments

5dac860

update comment

aecbcf9

Merge branch 'main' of github.com:decentraland/protocol into comms

e087373

Merge branch 'main' of github.com:decentraland/protocol into comms

30883c8

Merge branch 'main' into comms

4f8fb76

Merge branch 'main' of github.com:decentraland/protocol into comms

3365158

Merge branch 'comms' of github.com:decentraland/protocol into comms

1d279e3

Merge branch 'main' into comms

8576568

leanmendoza mentioned this pull request Jul 19, 2023

feat: (sdk) add player and avatar components #161

Merged

leanmendoza closed this May 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Player components and Comms extensions #144

Player components and Comms extensions #144

menduz commented May 4, 2023

github-actions bot commented May 4, 2023 •

edited

Loading

slezica left a comment •

edited

Loading

slezica May 19, 2023 •

edited

Loading

slezica May 19, 2023 •

edited

Loading

slezica May 19, 2023

slezica May 19, 2023 •

edited

Loading

slezica May 19, 2023 •

edited

Loading

leanmendoza commented May 10, 2024

Player components and Comms extensions #144

Player components and Comms extensions #144

Conversation

menduz commented May 4, 2023

github-actions bot commented May 4, 2023 • edited Loading

Test this pull request

slezica left a comment • edited Loading

Choose a reason for hiding this comment

slezica May 19, 2023 • edited Loading

Choose a reason for hiding this comment

Rationale for Component

Rationale for Custom

slezica May 19, 2023 • edited Loading

Choose a reason for hiding this comment

slezica May 19, 2023

Choose a reason for hiding this comment

slezica May 19, 2023 • edited Loading

Choose a reason for hiding this comment

slezica May 19, 2023 • edited Loading

Choose a reason for hiding this comment

leanmendoza commented May 10, 2024

github-actions bot commented May 4, 2023 •

edited

Loading

slezica left a comment •

edited

Loading

slezica May 19, 2023 •

edited

Loading

Rationale for `Component`

Rationale for `Custom`

slezica May 19, 2023 •

edited

Loading

slezica May 19, 2023 •

edited

Loading

slezica May 19, 2023 •

edited

Loading