Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player components and Comms extensions #144
Player components and Comms extensions #144
Changes from all commits
37eac37
3a3d11b
49b7f43
b8d55a5
a85bd7d
4ed3ee9
ae4e574
f3c10ae
523a10f
73ae4cc
908f271
86bc6c2
82bab20
ba7bcad
9780e3d
0ec081e
23fe6bd
c10dba3
4480d61
3d87f8b
c09d710
d2f1b84
f2a6d0b
5dac860
aecbcf9
e087373
30883c8
4f8fb76
3365158
1d279e3
8576568
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add some additional description for the
timestamp
field, as with the other two. It's unclear in this context (Components sent over comms) whether this is a Lamport timestamp, a Unix timestamp, or some other time-like value. The same name is used with afloat
type for milliseconds inPosition
, and there's a nice comment there 😄This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word
Customization
is a little long. How aboutMods
, for modifiers? I'm not sure, nothing better is coming to mind right now.