Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add adr content to specify the Map in any realms #206

Merged
merged 7 commits into from
Jul 22, 2024
Merged

feat: add adr content to specify the Map in any realms #206

merged 7 commits into from
Jul 22, 2024

Conversation

leanmendoza
Copy link
Contributor

@leanmendoza leanmendoza commented Jun 26, 2024 •
edited
Loading

Following spec
decentraland/adr#266

@leanmendoza leanmendoza mentioned this pull request Jun 26, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

Test this pull request

  • The @dcl/protocol package can be tested in scenes by running 
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-9940842023.commit-7dd52db.tgz"

marianogoldman
marianogoldman reviewed Jun 26, 2024
View reviewed changes
proto/decentraland/realm/about.proto Outdated Show resolved Hide resolved
proto/decentraland/realm/about.proto Outdated Show resolved Hide resolved
proto/decentraland/realm/about.proto Show resolved Hide resolved
@kuruk-mm kuruk-mm changed the title add adr content to detail miniamp in realms add adr content to detail minimap in realms Jul 1, 2024
kuruk-mm
kuruk-mm previously approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@kuruk-mm kuruk-mm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Just apply @marianogoldman review

@leanmendoza leanmendoza changed the title add adr content to detail minimap in realms add adr content to specify the Map in any realms Jul 10, 2024
@leanmendoza leanmendoza changed the title add adr content to specify the Map in any realms feat: add adr content to specify the Map in any realms Jul 10, 2024
@leanmendoza leanmendoza marked this pull request as ready for review July 10, 2024 15:57
@leanmendoza leanmendoza mentioned this pull request Jul 10, 2024
Open
kuruk-mm
kuruk-mm previously approved these changes Jul 10, 2024
View reviewed changes
proto/decentraland/realm/about.proto Outdated Show resolved Hide resolved
@leanmendoza @robtfm
Update proto/decentraland/realm/about.proto
dd65156 
Co-authored-by: robtfm <[email protected]>
Signed-off-by: Lean Mendoza <[email protected]>
@leanmendoza leanmendoza requested a review from robtfm July 15, 2024 15:03
robtfm
robtfm approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@robtfm robtfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

for genesis.city the max zoom level is 5, but i don't think it needs to be config (and explorers should fall back to lower levels if the higher ones aren't found anyway). might be worth a comment though?

kuruk-mm
kuruk-mm approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

pravusjif
pravusjif approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@pravusjif pravusjif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job!

@leanmendoza leanmendoza mentioned this pull request Jul 16, 2024
Merged
@leanmendoza leanmendoza merged commit ea61304 into main Jul 22, 2024
3 checks passed
@leanmendoza leanmendoza deleted the adr/minimap branch July 22, 2024 19:22
@leanmendoza leanmendoza mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pravusjif pravusjif pravusjif approved these changes

@kuruk-mm kuruk-mm kuruk-mm approved these changes

@robtfm robtfm robtfm approved these changes

@marianogoldman marianogoldman Awaiting requested review from marianogoldman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leanmendoza @marianogoldman @pravusjif @kuruk-mm @robtfm