-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trigger scene emotes for local development #2355
Draft
AlejandroAlvarezMelucciDCL
wants to merge
18
commits into
dev
Choose a base branch
from
fix/trigger-scene-emotes-for-local-development
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix: trigger scene emotes for local development #2355
AlejandroAlvarezMelucciDCL
wants to merge
18
commits into
dev
from
fix/trigger-scene-emotes-for-local-development
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and raw gltf for local scene development. Contains a LOT of wip code.
…es. Still heavily WIP
…ing during local scene development
…es and GLTFs for the loading pipeline.
AlejandroAlvarezMelucciDCL
removed the request for review
from Ludmilafantaniella
October 14, 2024 22:57
# Conflicts: # Explorer/Assets/DCL/PluginSystem/World/GltfContainerPlugin.cs # Explorer/Assets/Scripts/ECS/StreamableLoading/GLTF/LoadGLTFSystem.cs
AlejandroAlvarezMelucciDCL
removed request for
mikhail-dcl,
lorux0,
pravusjif and
dalkia
October 16, 2024 14:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
triggerSceneEmote
calls from the SDK were not working for local scene development (LSD), the reason being the code path for triggering scene emotes was highly coupled with AssetBundles and did not consider LSD at all. The code path fortriggerSceneEmote
is completly different than everything related to load raw gltf for LSD so it was overlooked.WHAT
Implemented a branch to trigger scene emotes both for LSD and AssetBundle normal flow. Implemented a bit of abstraction to introduce as less branching as possible and streamline the usage of asset data to trigger emotes. Fixed animation clips loading for raw gltf loading in LSD (not needed for AssetBundle's flow)
Fixes #2249
TEST STEPS
npm i
npm run start -- --explorer-alpha