Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger scene emotes for local development #2355

Draft
wants to merge 18 commits into
base: dev
Choose a base branch
from

Conversation

AlejandroAlvarezMelucciDCL
Copy link
Collaborator

@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL commented Oct 7, 2024

WHY

triggerSceneEmote calls from the SDK were not working for local scene development (LSD), the reason being the code path for triggering scene emotes was highly coupled with AssetBundles and did not consider LSD at all. The code path for triggerSceneEmote is completly different than everything related to load raw gltf for LSD so it was overlooked.

WHAT

Implemented a branch to trigger scene emotes both for LSD and AssetBundle normal flow. Implemented a bit of abstraction to introduce as less branching as possible and streamline the usage of asset data to trigger emotes. Fixed animation clips loading for raw gltf loading in LSD (not needed for AssetBundle's flow)

Fixes #2249


TEST STEPS

  1. Download this test scene
  2. Unzip it somewhere and enter its root folder with a console/terminal
  3. run npm i
  4. run npm run start -- --explorer-alpha
  5. Confirm that with the latest published E@ the scene emotes don't play by clicking the white boxes (2 should trigger Scene Emotes, one triggers normal Avatar Emotes)
  6. Close the Explorer but leave the scene running in the terminal
  7. Download the build from this PR
  8. Connect the PR build to the locally running scene, following the steps in the Wiki (remember to put the correct scene position parameter, in this case: --position 80,-1)
  9. Confirm that now you actually can trigger the 2 Scene Emotes, Craft Snowball and Throw Snowball

…s and raw gltf for local scene development. Contains a LOT of wip code.
Copy link

github-actions bot commented Oct 7, 2024

badge

Build failed! Check the logs to see what went wrong

@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL changed the base branch from main to dev October 8, 2024 20:12
# Conflicts:
#	Explorer/Assets/DCL/PluginSystem/World/GltfContainerPlugin.cs
#	Explorer/Assets/Scripts/ECS/StreamableLoading/GLTF/LoadGLTFSystem.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scene Emotes don't work with Local Scene Development
2 participants