Improve K8s demo setup instructions #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds small tweaks to the K8s setup instructions.
paullatzelsperger
requested changes
Sep 12, 2024
| @@ -328,6 +328,8 @@ Once all the deployments are up-and-running, the seed script needs to be execute | |||
| output similar to this: | |||
|
|
|||
| ```shell | |||
| # We are in `/deployment` and we need to go back to the root where the seed script resides | |||
| ❯ cd .. | |||
There was a problem hiding this comment.
this is not needed, as the documentation states that "every command executes from the root directory, unless stated otherwise"
| @@ -293,7 +293,7 @@ terraform init | |||
| terraform apply | |||
| ``` | |||
|
|
|||
| Once Terraform has completed the deployment, type `kubectl get pods` and verify the output: | |||
| Once Terraform has completed the deployment, type `kubectl get pods --namespace mvd` and verify the output: | |||
There was a problem hiding this comment.
not needed, the subsequent code example shows exactly that.
|
Closing the PR as the maintainers believe it doesn't provide significant value at this time. However, it can still serve as a helpful reference for others encountering similar issues in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This change adds small improvements to the K8s demo setup instructions.
Why it does that
I just went through the demo setup instruction from the command line and hit some of this small issues.