Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve K8s demo setup instructions #332

Closed
wants to merge 1 commit into from
Closed

Improve K8s demo setup instructions #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ terraform init
terraform apply
```

Once Terraform has completed the deployment, type `kubectl get pods` and verify the output:
Once Terraform has completed the deployment, type `kubectl get pods --namespace mvd` and verify the output:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed, the subsequent code example shows exactly that.


```shell
❯ kubectl get pods --namespace mvd
Expand Down Expand Up @@ -328,6 +328,8 @@ Once all the deployments are up-and-running, the seed script needs to be execute
output similar to this:

```shell
# We are in `/deployment` and we need to go back to the root where the seed script resides
❯ cd ..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed, as the documentation states that "every command executes from the root directory, unless stated otherwise"

❯ ./seed-k8s.sh


Expand Down Expand Up @@ -673,4 +675,4 @@ into the stores by an extension called `IdentityHubExtension.java` and are **dif
Kubernetes deployments.

The [JwtSigner.java](launchers/identity-hub/src/test/java/org/eclipse/edc/demo/dcp/JwtSigner.java) test class can be
used to re-generate and sign all credentials.
used to re-generate and sign all credentials.