Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grade-school description #2499

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Elahi-cs
Copy link

This PR follows this discussion on the forum. A complete list of the changes and their rationale can be seen there.

@Elahi-cs Elahi-cs requested a review from a team as a code owner November 17, 2024 19:24
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Nov 17, 2024
@BNAndras BNAndras reopened this Nov 17, 2024
@IsaacG
Copy link
Member

IsaacG commented Nov 17, 2024

I'm reluctant to change minor things that aren't actually incorrect. We don't want everyone that wants to contribute to come through and tweak language to their preference. That introduces a lot of churn. Feel free to correct grammatical errors. Please don't word smith just to word smith without prior approval via a forum discussion.

@IsaacG IsaacG closed this Nov 17, 2024
@Elahi-cs
Copy link
Author

I'm reluctant to change minor things that aren't actually incorrect. We don't want everyone that wants to contribute to come through and tweak language to their preference. That introduces a lot of churn. Feel free to correct grammatical errors. Please don't word smith just to word smith without prior approval via a forum discussion.

@IsaacG, thank you for your feedback. As stated in the PR description, there has already been a discussion in the forum, which I will link again here.

@IsaacG
Copy link
Member

IsaacG commented Nov 17, 2024

@IsaacG, thank you for your feedback. As stated in the PR description, there has already been a discussion in the forum, which I will link again here.

My apologies.

@IsaacG IsaacG reopened this Nov 17, 2024
Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small fix for consistency


Note that all our students only have one name (It's a small town, what do you want?) and each student cannot be added more than once to a grade or the roster.
In fact, when a test attempts to add the same student more than once, your implementation should indicate that this is incorrect.
Note that all our students only have one name (it’s a small town, what do you want?), and each student cannot be added more than once to a grade or the roster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note that all our students only have one name (its a small town, what do you want?), and each student cannot be added more than once to a grade or the roster.
Note that all our students only have one name (it's a small town, what do you want?), and each student cannot be added more than once to a grade or the roster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants