Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grade-school description #2499

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions exercises/grade-school/description.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
# Description

Given students' names along with the grade that they are in, create a roster for the school.
Given students' names along with the grade they are in, create a roster for the school.

In the end, you should be able to:

- Add a student's name to the roster for a grade
- Add a student's name to the roster for a grade:
- "Add Jim to grade 2."
- "OK."
- Get a list of all students enrolled in a grade
- Get a list of all students enrolled in a grade:
- "Which students are in grade 2?"
- "We've only got Jim just now."
- "We've only got Jim right now."
- Get a sorted list of all students in all grades.
Grades should sort as 1, 2, 3, etc., and students within a grade should be sorted alphabetically by name.
- "Who all is enrolled in school right now?"
Grades should be sorted as 1, 2, 3, etc., and students within a grade should be sorted alphabetically by name.
- "Who is enrolled in school right now?"
- "Let me think.
We have Anna, Barb, and Charlie in grade 1, Alex, Peter, and Zoe in grade 2 and Jim in grade 5.
So the answer is: Anna, Barb, Charlie, Alex, Peter, Zoe and Jim"
Cool-Katt marked this conversation as resolved.
Show resolved Hide resolved
We have Anna, Barb, and Charlie in grade 1, Alex, Peter, and Zoe in grade 2, and Jim in grade 5.
So the answer is: Anna, Barb, Charlie, Alex, Peter, Zoe, and Jim."

Note that all our students only have one name (It's a small town, what do you want?) and each student cannot be added more than once to a grade or the roster.
In fact, when a test attempts to add the same student more than once, your implementation should indicate that this is incorrect.
Note that all our students only have one name (it’s a small town, what do you want?), and each student cannot be added more than once to a grade or the roster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note that all our students only have one name (its a small town, what do you want?), and each student cannot be added more than once to a grade or the roster.
Note that all our students only have one name (it's a small town, what do you want?), and each student cannot be added more than once to a grade or the roster.

If a test attempts to add the same student more than once, your implementation should indicate that this is incorrect.