Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeReviewComments: avoid using naked returns #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

CodeReviewComments: avoid using naked returns #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions CodeReviewComments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,10 +464,9 @@ is less clear than:
func (f *Foo) Location() (lat, long float64, err error)
```

Naked returns are okay if the function is a handful of lines. Once it's a medium
sized function, be explicit with your return values. Corollary: it's not worth it
to name result parameters just because it enables you to use naked returns.
Clarity of docs is always more important than saving a line or two in your function.
Avoid using naked returns. Corollary: do not name result parameters just
because it enables you to use naked returns. Clarity of docs is always more
important than saving a line or two in your function.

Finally, in some cases you need to name a result parameter in order to change
it in a deferred closure. That is always OK.
Expand Down