PR #16696: Various macOS QOL enchancements #2674
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Imported from GitHub PR openxla/xla#16696 This PR adds various small quality of life improvements to macOS builds: - drop the `.so` suffix for PjRt plugin targets (`.dylib` on macOS) - add compatibility with Apple Command Line Tools (no need for Xcode anymore) - only export the `GetPjrtApi` symbol on macOS - leverage bazel's `cc_binary.additional_linker_inputs` instead of using `deps` It is probable the `.so` change my break some other builds, but I couldn't find any use in the XLA repo to patch ? Copybara import of the project: -- 2d392b016730e8811ea72f90d9b5ee67126e61e6 by Steeve Morin <[email protected]>: [PjRt] Only export GetPjrtApi symbol on macOS Also add missing macOS linkops, remove the .so suffix to the plugin targets and add additional_linker_inputs for the linker script instead of deps. -- 9dbba3433bd88d3db95f1647782ba3bf9d3462cf by Steeve Morin <[email protected]>: Do not force DEVELOPER_DIR on macOS It's is autodetected by Bazel and supports building using only the Apple Command Line Tools. -- 336122e2fb0e3d7dd93b5a4a30f7551d8e1a21b6 by Steeve Morin <[email protected]>: Set the macosx deployment target via the bazel command line Instead of via an action env. Merging this change closes #16696 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#16696 from zml:steeve/cc_shared_library 336122e2fb0e3d7dd93b5a4a30f7551d8e1a21b6 PiperOrigin-RevId: 673069979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #16696: Various macOS QOL enchancements
Imported from GitHub PR openxla/xla#16696
This PR adds various small quality of life improvements to macOS builds:
.sosuffix for PjRt plugin targets (.dylibon macOS)GetPjrtApisymbol on macOScc_binary.additional_linker_inputsinstead of usingdepsIt is probable the
.sochange my break some other builds, but I couldn't find any use in the XLA repo to patch ?Copybara import of the project:
--
2d392b016730e8811ea72f90d9b5ee67126e61e6 by Steeve Morin [email protected]:
[PjRt] Only export GetPjrtApi symbol on macOS
Also add missing macOS linkops, remove the .so suffix to the plugin targets
and add additional_linker_inputs for the linker script instead of deps.
--
9dbba3433bd88d3db95f1647782ba3bf9d3462cf by Steeve Morin [email protected]:
Do not force DEVELOPER_DIR on macOS
It's is autodetected by Bazel and supports building using
only the Apple Command Line Tools.
--
336122e2fb0e3d7dd93b5a4a30f7551d8e1a21b6 by Steeve Morin [email protected]:
Set the macosx deployment target via the bazel command line
Instead of via an action env.
Merging this change closes #16696
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#16696 from zml:steeve/cc_shared_library 336122e2fb0e3d7dd93b5a4a30f7551d8e1a21b6