Commits on Sep 10, 2024

1. PR #16696: Various macOS QOL enchancements …

   Imported from GitHub PR openxla/xla#16696
   
   This PR adds various small quality of life improvements to macOS builds:
   - drop the `.so` suffix for PjRt plugin targets (`.dylib` on macOS)
   - add compatibility with Apple Command Line Tools (no need for Xcode anymore)
   - only export the `GetPjrtApi` symbol on macOS
   - leverage bazel's `cc_binary.additional_linker_inputs` instead of using `deps`
   
   It is probable the `.so` change my break some other builds, but I couldn't find any use in the XLA repo to patch ?
   Copybara import of the project:
   
   --
   2d392b016730e8811ea72f90d9b5ee67126e61e6 by Steeve Morin <[email protected]>:
   
   [PjRt] Only export GetPjrtApi symbol on macOS
   
   Also add missing macOS linkops, remove the .so suffix to the plugin targets
   and add additional_linker_inputs for the linker script instead of deps.
   
   --
   9dbba3433bd88d3db95f1647782ba3bf9d3462cf by Steeve Morin <[email protected]>:
   
   Do not force DEVELOPER_DIR on macOS
   
   It's is autodetected by Bazel and supports building using
   only the Apple Command Line Tools.
   
   --
   336122e2fb0e3d7dd93b5a4a30f7551d8e1a21b6 by Steeve Morin <[email protected]>:
   
   Set the macosx deployment target via the bazel command line
   
   Instead of via an action env.
   
   Merging this change closes #16696
   
   FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#16696 from zml:steeve/cc_shared_library 336122e2fb0e3d7dd93b5a4a30f7551d8e1a21b6
   PiperOrigin-RevId: 673069979

   

   steeve authored and copybara-github committed Sep 10, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for dfb8550
   • Browse repository at this point

   Copy the full SHA

   dfb8550 View commit details

   Browse the repository at this point in the history