Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: reduce number of SQL queries in GET_TASKS #2135

Draft
wants to merge 46 commits into
base: main
Choose a base branch
from
Draft

Change: reduce number of SQL queries in GET_TASKS #2135

wants to merge 46 commits into from

Conversation

mattmundell
Copy link
Contributor

What

Why

References

Waits for /pull/2131

mattmundell and others added 30 commits January 2, 2024 19:39
@mattmundell
Change: Check trash target references before accessing
88c2bff 
In the trash case of GET_TARGETS check that dependent resources like
credentials exist before trying to access info about them.  This
speeds up the GSA trashcan, by skipping some SQL queries that would
always return NULL.
@mattmundell
Move variables to where they are used
decd117
@mattmundell
Combine CREDENTIAL_ITERATOR_COLUMNS and CREDENTIAL_ITERATOR_TRASH_COL…
4d55aa0 
…UMNS
@mattmundell
Make credential_iterator_format_available variable use more obvious
15661bf
@mattmundell
Note credential iterator field use
222f9aa
@mattmundell
Change: Use fewer queries in credential iterator when possible
fc8765d
@mattmundell
Declare variables where they are used
f0d4458
@mattmundell
Move get_task_schedule_xml into branches
2da21a6
@mattmundell
Move task_target into branch that uses it
9fdaaa0
@mattmundell
Move get_iterator_resource into branches
fb8882d
@mattmundell
Move schedules_only case out to function
e09e764
@mattmundell
Use send instead of sendf for simple string
65f515f
@mattmundell
Use new function sendf_to_client instead of obscure macro
2ff4aeb
@mattmundell
Make sendf_to_client more convenient
ef27916
@mattmundell
Make send_find_error_to_client more convenient
7487ae0
@mattmundell
Make send_to_client more convenient
b442180
@mattmundell
Move sending of task out to function
23590d7
@mattmundell
Merge branch 'main' into faster-trash-tasks
df91d62
@mattmundell
Get get_tasks_send_task working
9fc89cf
@mattmundell
Fix indent of large string
f345791
@mattmundell
Make large string more manageable
9e8fbde
@mattmundell
Neaten start of get_tasks_send_task
3bf8b72
@mattmundell
Move current_report setup out to function
e97ac39
@mattmundell
Move last_report setup out to function
1f88070
@mattmundell
Move sending of observers out to function
230ed1c
@mattmundell
Move sending of alerts out to function
bf71f23
@mattmundell
Move sending of preferences out to function
45edb72
@mattmundell
Define variables after declarations
c2e368c
@mattmundell
Group more declarations
79e3085
@mattmundell
Merge branch 'main' into faster-trash-tasks
b38ea71
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

Conventional Commits Report

Type Number
Bug Fixes 1
Changed 2

🚀 Conventional commits found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattmundell