Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: reduce number of SQL queries in GET_TASKS #2135

Draft
wants to merge 46 commits into
base: main
Choose a base branch
from
Draft

Change: reduce number of SQL queries in GET_TASKS #2135

wants to merge 46 commits into from

Commits on Jan 2, 2024

  1. Change: Check trash target references before accessing 

    In the trash case of GET_TARGETS check that dependent resources like
credentials exist before trying to access info about them.  This
speeds up the GSA trashcan, by skipping some SQL queries that would
always return NULL.
    @mattmundell
    mattmundell committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    88c2bff View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Move variables to where they are used

    @mattmundell
    mattmundell committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    decd117 View commit details
    Browse the repository at this point in the history

  2. Combine CREDENTIAL_ITERATOR_COLUMNS and CREDENTIAL_ITERATOR_TRASH_COL… 

    …UMNS
    @mattmundell
    mattmundell committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    4d55aa0 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Make credential_iterator_format_available variable use more obvious

    @mattmundell
    mattmundell committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    15661bf View commit details
    Browse the repository at this point in the history

  2. Note credential iterator field use

    @mattmundell
    mattmundell committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    222f9aa View commit details
    Browse the repository at this point in the history

  3. Change: Use fewer queries in credential iterator when possible

    @mattmundell
    mattmundell committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    fc8765d View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Declare variables where they are used

    @mattmundell
    mattmundell committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f0d4458 View commit details
    Browse the repository at this point in the history

  2. Move get_task_schedule_xml into branches

    @mattmundell
    mattmundell committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2da21a6 View commit details
    Browse the repository at this point in the history

  3. Move task_target into branch that uses it

    @mattmundell
    mattmundell committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9fdaaa0 View commit details
    Browse the repository at this point in the history

  4. Move get_iterator_resource into branches

    @mattmundell
    mattmundell committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    fb8882d View commit details
    Browse the repository at this point in the history

  5. Move schedules_only case out to function

    @mattmundell
    mattmundell committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e09e764 View commit details
    Browse the repository at this point in the history

  6. Use send instead of sendf for simple string

    @mattmundell
    mattmundell committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    65f515f View commit details
    Browse the repository at this point in the history

  7. Use new function sendf_to_client instead of obscure macro

    @mattmundell
    mattmundell committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2ff4aeb View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Make sendf_to_client more convenient

    @mattmundell
    mattmundell committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    ef27916 View commit details
    Browse the repository at this point in the history

  2. Make send_find_error_to_client more convenient

    @mattmundell
    mattmundell committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    7487ae0 View commit details
    Browse the repository at this point in the history

  3. Make send_to_client more convenient

    @mattmundell
    mattmundell committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b442180 View commit details
    Browse the repository at this point in the history

  4. Move sending of task out to function

    @mattmundell
    mattmundell committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    23590d7 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Merge branch 'main' into faster-trash-tasks

    @mattmundell
    mattmundell authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    df91d62 View commit details
    Browse the repository at this point in the history

  2. Get get_tasks_send_task working

    @mattmundell
    mattmundell committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    9fc89cf View commit details
    Browse the repository at this point in the history

  3. Fix indent of large string

    @mattmundell
    mattmundell committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    f345791 View commit details
    Browse the repository at this point in the history

  4. Make large string more manageable

    @mattmundell
    mattmundell committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    9e8fbde View commit details
    Browse the repository at this point in the history

  5. Neaten start of get_tasks_send_task

    @mattmundell
    mattmundell committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    3bf8b72 View commit details
    Browse the repository at this point in the history

  6. Move current_report setup out to function

    @mattmundell
    mattmundell committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    e97ac39 View commit details
    Browse the repository at this point in the history

  7. Move last_report setup out to function

    @mattmundell
    mattmundell committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    1f88070 View commit details
    Browse the repository at this point in the history

  8. Move sending of observers out to function

    @mattmundell
    mattmundell committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    230ed1c View commit details
    Browse the repository at this point in the history

  9. Move sending of alerts out to function

    @mattmundell
    mattmundell committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    bf71f23 View commit details
    Browse the repository at this point in the history

  10. Move sending of preferences out to function

    @mattmundell
    mattmundell committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    45edb72 View commit details
    Browse the repository at this point in the history

  11. Define variables after declarations

    @mattmundell
    mattmundell committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    c2e368c View commit details
    Browse the repository at this point in the history

  12. Group more declarations

    @mattmundell
    mattmundell committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    79e3085 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into faster-trash-tasks

    @mattmundell
    mattmundell authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    b38ea71 View commit details
    Browse the repository at this point in the history

  14. Clang format

    @mattmundell
    mattmundell committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    7b76bd9 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Move task end tag back to get_tasks_send_task

    @mattmundell
    mattmundell committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    d1e1689 View commit details
    Browse the repository at this point in the history

  2. Use new function task_info to save queries in get_tasks_send_task

    @mattmundell
    mattmundell committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    7e34dca View commit details
    Browse the repository at this point in the history

  3. Fix stray commas

    @mattmundell
    mattmundell committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    483b923 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Move config_in_trash SQL into task_info

    @mattmundell
    mattmundell committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9977548 View commit details
    Browse the repository at this point in the history

  2. Fix missing else

    @mattmundell
    mattmundell committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    88b02d4 View commit details
    Browse the repository at this point in the history

  3. Use WITH for config_in_trash

    @mattmundell
    mattmundell committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9c02e89 View commit details
    Browse the repository at this point in the history

  4. Combine task_info SQL into single statement

    @mattmundell
    mattmundell committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    c808fd9 View commit details
    Browse the repository at this point in the history

  5. Move second_last_report_id into task_info

    @mattmundell
    mattmundell committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6f3f98a View commit details
    Browse the repository at this point in the history

  6. Move scanner_in_trash to task_info

    @mattmundell
    mattmundell committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    3e5716b View commit details
    Browse the repository at this point in the history

  7. Move other scanner queries to task_info

    @mattmundell
    mattmundell committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7b6e8c7 View commit details
    Browse the repository at this point in the history

  8. Fix: check if trash when getting scanner info in GET_TASKS

    @mattmundell
    mattmundell committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    225b279 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Call scanner SQL directly in task_info

    @mattmundell
    mattmundell committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    14b1da6 View commit details
    Browse the repository at this point in the history

  2. Move scanner SQL into main statement in task_info

    @mattmundell
    mattmundell committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    a5f76b5 View commit details
    Browse the repository at this point in the history

  3. Actually set second_last_report_id in task_info

    @mattmundell
    mattmundell committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    9f1322c View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Merge branch 'main' into faster-trash-tasks-2

    @mattmundell
    mattmundell authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    70576f3 View commit details
    Browse the repository at this point in the history