Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use organization scoped adapters like @hubot-friends/hubot-slack #1655

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

joeyguerra
Copy link
Member

@joeyguerra joeyguerra commented Jul 29, 2023

BREAKING CHANGE: This change now requires you to include hubot- when specifying hubot adapters.

fixes #1654

BREAKING CHANGE: This change now requires you to include hubot- when specifying hubot adapters.
@joeyguerra joeyguerra merged commit ac5dcd2 into main Jul 29, 2023
5 checks passed
@joeyguerra joeyguerra deleted the org-scoped-adapter branch July 29, 2023 23:24
@github-actions
Copy link

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KeesCBakker
Copy link
Contributor

Hi, I see that you reference "@hubot-friends/hubot-slack". What is that?

(I'm looking for a new Slack adapter that uses Bolt instead of the RTM API)

@KeesCBakker
Copy link
Contributor

@joeyguerra
Copy link
Member Author

Yes, that's the one I'm referring to. Please note that it's a fork of the old hubot-slack adapter and EXTENSIVELY modified to utilize @slack/web-api and @slack/socket-mode, replacing Slacks RTM client from @slack/client.

It doesn't use Bolt.

I would love your critical feedback if you use it though.

@KeesCBakker
Copy link
Contributor

KeesCBakker commented Aug 1, 2023

At Wehkamp we have a jump-start project for Hubot / Slack chat bots. We have a public base here: https://github.com/wehkamp/bot-zero

With some internal bots we try to add dialog features to the bot, for which we might need bolt (but I'm not sure if I fully understand the difference between socket mode and bolt, as Slack muddies the communication a bit).

The main things we don't want to loose are hubot-grafana and hubot-pager-me, so we're really happy that you came up with something that works with a modern Slack app. Super kudos!

@KeesCBakker
Copy link
Contributor

@joeyguerra looks like we might need to add support to hubot-grafana for the special adapterName as well: stephenyeargin/hubot-grafana#156

@KeesCBakker
Copy link
Contributor

@joeyguerra can you check hubot-friends/hubot-slack#21 for better error handling? I think if we have that in the package we get a better handle on what's going wrong if the Slack API does not want to eat our request.

@joeyguerra
Copy link
Member Author

@KeesCBakker yes. Will collaborate more over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Organization Scoped packages as adapters
2 participants