Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gazebo namespaces #91

Closed
wants to merge 77 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
2213a81
added namespaces to ros2_control
delihus Nov 13, 2023
2b479a6
removed action group
delihus Nov 13, 2023
ae14e26
Added namespace to robot description
delihus Nov 13, 2023
2b37af8
added tests for namespaces in rosbot_controller
delihus Nov 13, 2023
72bef34
update worldlist
delihus Nov 13, 2023
0d82f27
fixed ros2_control namespaces | added namespace to ekf
delihus Nov 13, 2023
ad2ef7c
added mecanum
delihus Nov 13, 2023
64952ce
added ros2_controllers to .gitignore
delihus Nov 13, 2023
9a3e90d
ignored ros2_controllers during Industrial CI
delihus Nov 14, 2023
539cd89
fixed tests
delihus Nov 14, 2023
976a6da
added tf_prefix to imu_sensor_broadcaster
delihus Nov 14, 2023
d0274a6
copied only diff_drive and imu_broadcaster
delihus Nov 14, 2023
1df3216
changed comments | changed timeout for controller test
delihus Nov 14, 2023
86c7588
param changed to parameter
delihus Nov 14, 2023
4a783a6
Multi robot diff drive example
delihus Nov 28, 2023
9d850bf
imu also works
delihus Nov 28, 2023
02fe7d2
Added use_multirobot_system | found imu error
delihus Nov 28, 2023
1b8d92f
changed all topics to ns
delihus Nov 28, 2023
5cd3a69
removed tf_prefix from xacro tests
delihus Nov 28, 2023
f5a9597
removed comments | add use_multirobot_system arg
delihus Nov 28, 2023
297ebc1
moved multi robot system controllers config to rosbot_controller
delihus Nov 28, 2023
9cf6c1b
fixed rosbot_gazebo test
delihus Nov 28, 2023
1ad2db6
separated namespaced tests | added multirobot gazebo example with bro…
delihus Nov 29, 2023
1e0f69d
add multicontroller test
delihus Nov 29, 2023
3ea4d16
add multibringup test
delihus Nov 29, 2023
568063b
add multibringup test
delihus Nov 29, 2023
2e5b6cf
Added remove rosbot_macro
delihus Nov 29, 2023
cd3e104
fixed miss spelling
delihus Nov 29, 2023
b831fd5
The change from robot_hardware_interface seems to be unnecessary
delihus Nov 29, 2023
11fcac8
moved multirobot tests to arrays
delihus Nov 29, 2023
5802601
move rosbot_hardware_interfaces to main
delihus Nov 29, 2023
9019ff3
Fixed len
delihus Nov 29, 2023
165085b
Added updated controllers info to readme
delihus Nov 30, 2023
9afd60c
Gazebo test (#86)
rafal-gorecki Dec 5, 2023
e05b777
Update changelog
Dec 5, 2023
74ff66e
0.10.5
Dec 5, 2023
7eab9e8
Added gazebo remappings file
delihus Dec 5, 2023
967df74
Added namespace to mappings
delihus Dec 5, 2023
e3b4ce0
Merge remote-tracking branch 'origin/humble' into add-gazebo-namespaces
delihus Dec 5, 2023
4a3db5c
fixed clock | added camera
delihus Dec 5, 2023
d4abcc5
working without multisystem
delihus Dec 5, 2023
cba7f16
parse robots arg | removed delays from rosbot_controller
delihus Dec 27, 2023
65179d2
Merge remote-tracking branch 'origin/humble' into add-gazebo-namespaces
delihus Dec 27, 2023
d11a464
TEsting
delihus Dec 27, 2023
aee0756
fixed imu while testing
delihus Dec 28, 2023
b88cbd9
Multirobots tests
delihus Dec 28, 2023
ab53ca9
all gazebo tests
delihus Dec 28, 2023
cf197ba
changed to namespaced repositories
delihus Dec 28, 2023
273ddeb
revert headless to tests
delihus Dec 28, 2023
61825c3
IMU name with slash
delihus Dec 28, 2023
712cd9d
removed delay from spawning
delihus Dec 28, 2023
ec1ce0a
added name for ign_ros2_controller
delihus Dec 29, 2023
25009f1
fixed submodule
delihus Dec 29, 2023
79d82ff
checking mecanum controller sim time true
delihus Dec 29, 2023
ad156c1
Update industrial_ci.yaml
delihus Jan 2, 2024
50c90e5
removed coltroller test for testing timeout
delihus Jan 2, 2024
f58a967
removed bringup tests for testing timeout
delihus Jan 2, 2024
23f6432
used launch_ros features
delihus Jan 2, 2024
d796c38
Added unbuffered to skip list
delihus Jan 2, 2024
18a9485
added microros submodules to ignore and removed ros2 control demos fr…
delihus Jan 3, 2024
b011d70
removed controller test for actopn check
delihus Jan 3, 2024
3ee321e
removed gazebo tests
delihus Jan 3, 2024
9c87d38
Revert "removed coltroller test for testing timeout"
delihus Jan 3, 2024
de3951d
set timeout to 20
delihus Jan 3, 2024
aa6e9f4
Revert "removed controller test for actopn check"
delihus Jan 3, 2024
fd04e0b
Revert "Revert "removed controller test for actopn check""
delihus Jan 3, 2024
3af2a65
Revert "removed bringup tests for testing timeout"
delihus Jan 3, 2024
00efb4b
Revert "Revert "Revert "removed controller test for actopn check"""
delihus Jan 3, 2024
5000063
Revert "removed gazebo tests"
delihus Jan 3, 2024
d1550db
removed namespaced and multi robots test
delihus Jan 3, 2024
ff21951
removed sim tests
delihus Jan 3, 2024
b1fb857
Revert "removed sim tests"
delihus Jan 4, 2024
7ea5045
Revert "removed namespaced and multi robots test"
delihus Jan 4, 2024
bc76b8f
Testing...
delihus Jan 4, 2024
b2108ee
Update .wordlist.txt
delihus Jan 9, 2024
6cacf89
check CI
delihus Jan 9, 2024
6e9e0db
Merge remote-tracking branch 'origin/add-gazebo-namespaces' into add-…
delihus Jan 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/industrial_ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
ros_industrial_ci:
name: ROS Industrial CI
runs-on: ubuntu-22.04
timeout-minutes: 30 # Set the job timeout to 30 minutes
timeout-minutes: 20
needs:
- black
- spellcheck
Expand Down Expand Up @@ -63,6 +63,10 @@ jobs:
cp -r src/ros2_controllers/imu_sensor_broadcaster src/
rm -rf src/ros2_controllers

- name: Remove ign_ros2_control demo
shell: bash
run: rm -rf src/gazebosim/gz_ros2_control/ign_ros2_control_demos src/gazebosim/gz_ros2_control/gz_ros2_control_tests

# Package micro_ros_msgs does not have industrial ci and tests does not pass.
# For more information see https://github.com/micro-ROS/micro_ros_msgs/issues/7
- name: Remove tests from micro_ros_msgs
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ husarion/husarion_office_gz
gazebosim/gz_ros2_control
diff_drive_controller
imu_sensor_broadcaster
micro-ROS-Agent/
micro_ros_msgs/

# pyspelling
*.dic
2 changes: 2 additions & 0 deletions .wordlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -148,3 +148,5 @@ stm
ttyUSB
subprocess
cbus
unbuffered
psutil
6 changes: 3 additions & 3 deletions rosbot/rosbot_hardware.repos
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,18 @@ repositories:
ros_components_description:
type: git
url: https://github.com/husarion/ros_components_description.git
version: ros2
version: gazebo-ignition-multirobots
rosbot_controllers:
type: git
url: https://github.com/husarion/rosbot_controllers
version: main
version: update-params
# Waiting for backporting to the humble version
# https://github.com/ros-controls/ros2_controllers/pull/726 and
# https://github.com/ros-controls/ros2_controllers/pull/831
ros2_controllers:
type: git
url: https://github.com/delihus/ros2_controllers
version: humble-backport
version: imu-sensor-broadcaster-features
micro_ros_msgs:
type: git
url: https://github.com/micro-ROS/micro_ros_msgs.git
Expand Down
5 changes: 3 additions & 2 deletions rosbot/rosbot_simulation.repos
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
repositories:
gazebosim/gz_ros2_control:
type: git
url: https://github.com/ros-controls/gz_ros2_control.git
# Added feature with control manager name. Waiting on https://github.com/ros-controls/gz_ros2_control/pull/212
url: https://github.com/delihus/gz_ros2_control
version: humble

husarion/husarion_office_gz:
type: git
url: https://github.com/husarion/husarion_office_gz
version: main
version: add-gazebo-plugins
9 changes: 0 additions & 9 deletions rosbot_bringup/launch/bringup.launch.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,6 @@ def generate_launch_description():
),
)

use_multirobot_system = LaunchConfiguration("use_multirobot_system")
declare_use_multirobot_system_arg = DeclareLaunchArgument(
"use_multirobot_system",
default_value="false",
description="Enable correct Ignition Gazebo configuration in URDF",
)

controller_launch = IncludeLaunchDescription(
PythonLaunchDescriptionSource(
PathJoinSubstitution(
Expand All @@ -85,7 +78,6 @@ def generate_launch_description():
"use_gpu": use_gpu,
"simulation_engine": simulation_engine,
"namespace": namespace,
"use_multirobot_system": use_multirobot_system,
}.items(),
)

Expand All @@ -110,7 +102,6 @@ def generate_launch_description():
declare_use_sim_arg,
declare_use_gpu_arg,
declare_simulation_engine_arg,
declare_use_multirobot_system_arg,
SetParameter(name="use_sim_time", value=use_sim),
controller_launch,
robot_localization_node,
Expand Down
2 changes: 1 addition & 1 deletion rosbot_bringup/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<exec_depend>launch_ros</exec_depend>
<exec_depend>rosbot_controller</exec_depend>
<exec_depend>robot_localization</exec_depend>
<exec_depend>micro_ros_agent</exec_depend>
<!-- <exec_depend>micro_ros_agent</exec_depend> -->

<test_depend>python3-pytest</test_depend>
<test_depend>launch</test_depend>
Expand Down
23 changes: 0 additions & 23 deletions rosbot_bringup/test/test_copyright.py

This file was deleted.

67 changes: 0 additions & 67 deletions rosbot_bringup/test/test_diff_drive_ekf.py

This file was deleted.

23 changes: 0 additions & 23 deletions rosbot_bringup/test/test_flake8.py

This file was deleted.

67 changes: 0 additions & 67 deletions rosbot_bringup/test/test_mecanum_ekf.py

This file was deleted.

79 changes: 0 additions & 79 deletions rosbot_bringup/test/test_multirobot_ekf.py

This file was deleted.

Loading
Loading