chore: ci check to ensure generation has been run #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it works! 😆 |
lukebond
commented
Oct 19, 2023
There was a problem hiding this comment.
this was a missing generated file. unrelated to this PR
lukebond
commented
Oct 19, 2023
There was a problem hiding this comment.
this was a missing generated file. unrelated to this PR
|
this is sweet. thanks. |
zawachte
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a recent PR i pushed changes that included CRD changes, but i didn't regenerate the manifests.
this PR introduces a check that will fail if the developer forgets to do this.
note that it now runs
make buildon PRs, LMK if this is too much CI compute/cost and i can pare it back to just the generation jobs.