Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ci check to ensure generation has been run #65

Merged
merged 3 commits into from
Oct 19, 2023
Merged

chore: ci check to ensure generation has been run #65

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffcb011
chore: ci check to ensure generation has been run
lukebond Oct 19, 2023
38aa973
chore: remove make build from ci; add generated files
lukebond Oct 19, 2023
39f044c
chore: add generated files
lukebond Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,6 @@ jobs:

- name: ${{ matrix.target }}
run: make ${{ matrix.target }}

- name: check there are no changes after re-generation
run: test -z "$(git status --porcelain)" || (echo 'Changes detected after running make build'; git status; git --no-pager diff; false)
4 changes: 3 additions & 1 deletion bootstrap/config/crd/bases/controlplane.cluster.x-k8s.io_kthreescontrolplanes.yaml
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a missing generated file. unrelated to this PR

Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ spec:
properties:
infrastructureTemplate:
description: InfrastructureTemplate is a required reference to a custom
resource offered by an infrastructure provider.
resource offered by an infrastructure provider. In the next API
version we will move this into the `KThreesControlPlaneMachineTemplate`
struct. See https://github.com/cluster-api-provider-k3s/cluster-api-k3s/issues/62
properties:
apiVersion:
description: API version of the referent.
Expand Down
Loading