Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc-tester: implment --headless flag #350

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Conversation

iameli
Copy link
Collaborator

@iameli iameli commented Dec 5, 2023

For playing around with a local node and watching it happen.

@iameli iameli requested a review from victorges December 5, 2023 22:30
@iameli iameli requested a review from a team as a code owner December 5, 2023 22:30
@@ -48,6 +49,7 @@ func Player() {
fs.DurationVar(&cliFlags.TestDuration, "duration", 1*time.Minute, "How long to run the test")
utils.URLVarFlag(fs, &cliFlags.ScreenshotFolderOS, "screenshot-folder-os", "", "Object Store URL for a folder where to save screenshots of the player. If unset, no screenshots will be taken")
fs.DurationVar(&cliFlags.ScreenshotPeriod, "screenshot-period", 1*time.Minute, "How often to take a screenshot of the player")
fs.BoolVar(&cliFlags.Headless, "headless", true, "Run Chrome in headless mode (no-GUI)")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess Mist will never need to start this process right xD

chromedp.Flag("mute-audio", false),
)
}
allocCtx, cancel := chromedp.NewExecAllocator(context.Background(), opts...)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
image

@iameli iameli enabled auto-merge December 6, 2023 22:39
@iameli iameli merged commit 0797084 into master Dec 6, 2023
12 of 14 checks passed
@iameli iameli deleted the eli/webrtc-tester-hacking branch December 6, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants